Remove unused JS from react-dom

  • Resolved simd59

    (@simd59)


    2 years, 9 months ago

    hi,

    First of all, thank you for your excellent plugin. 🙂

    Secondly, if you don’t know me I am an expert in Web optimization. And I have multiple websites and websites from client who has your plugin. But, today I have a huge problem who make me doubted about the plugin.
    I have this error in Lighthouse : https://ibb.co/yV8MjhW
    If you can’t see the image it’s “Remove unused JavaScript : 0.6s…” from react-dom.min.js

    It’s only from your plugin, if I made it “asynchrones” the stars don’t show again… So the only solution is to use React.lazy() or code-split…

    Do you think you can do it for a next release ?

    It would be perfect, otherwise I will have to find another solution 🙁

    Than you so much.

    Kevin from KevOPTI

Viewing 15 replies - 1 through 15 (of 16 total)
1 2
  • Plugin Contributor dudo

    (@dudo)

    2 years, 9 months ago

    Hello!

    Thank you for sharing this.

    I’m working on this, not sure if the fix will be available in the next version or in the later one.

    Best,
    Dario

    Thread Starter simd59

    (@simd59)

    2 years, 9 months ago

    Thanks Dario,
    I can’t wait to see your fix ^^

    danigomu

    (@danigomu)

    2 years, 8 months ago

    Hi, I just got to this post trying to fix this problem on Lighthouse.

    I was very happy that Dario is already working on the solution. May I ask if this goes ahead? Is there anything that can be done at the user level to remove this lock until Dario has the definitive solution?

    @simd59 How did you do it?

    Thanks a lot.

    Thread Starter simd59

    (@simd59)

    2 years, 8 months ago

    Hi @danigomu
    No, when I saw the message from Dudo telling it will work on a fix I’ve stopped investigate.
    So for now, i’m still waiting for Dudo for the fix ^^
    @dudo some news ?

    Thanks

    Plugin Contributor dudo

    (@dudo)

    2 years, 8 months ago

    Hi guys, I’m in vacation right now and I will come back to work the next Monday.

    I did some tests last month, and found a partial solution (where this problem only appear if rankings are used into the posts)

    Then I needed to work on Gutenberg blocks.

    I will check this again and let you know.

    Best,
    Dario

    Thread Starter simd59

    (@simd59)

    2 years, 8 months ago

    Great thank you @dudo Enjoy you vacation 🙂

    danigomu

    (@danigomu)

    2 years, 8 months ago

    Great, we look forward to testing the solution when it is implemented.

    Ah, enjoy your vacation !! 🙂

    Plugin Contributor dudo

    (@dudo)

    2 years, 8 months ago

    I’m rewriting a lot of code, in version 2.8.5 js assets will be loaded only if shortcode exists in a post or page (now are loaded even in page with no shortcodes) and every shortcode will have his own js file instead of single bundle for the front end: so, less unused code will be loaded

    Thread Starter simd59

    (@simd59)

    2 years, 8 months ago

    Yeeah thanks Dario, I will make some test after you upload it but it looks great 🙂

    danigomu

    (@danigomu)

    2 years, 8 months ago

    Hello @dudo,

    Thank you for your work. So what will be the most optimized configuration? Between shortcode or automatic insertion will be any difference?

    In my blog I use a generatepress hook to insert the shortcode in the posts and pages that I want. So would the problem with the react-dom.min.js disappear in the next version of the plugin?

    Sorry for the questions but I don’t know if I understood correctly. Thanks.

    Plugin Contributor dudo

    (@dudo)

    2 years, 8 months ago

    @danigomu

    Between shortcode or automatic insertion will be any difference?

    No.

    So would the problem with the react-dom.min.js disappear in the next version of the plugin?

    If you’re not using any ranking shortcode, yes, the problem with react-dom.min.js will disappear.

    danigomu

    (@danigomu)

    2 years, 8 months ago

    If you’re not using any ranking shortcode, yes, the problem with react-dom.min.js will disappear.

    No, I’m only using this shortcode in all my posts: [yasr_visitor_votes size=”medium”]

    Plugin Contributor dudo

    (@dudo)

    2 years, 8 months ago

    Perfect then 😉

    Plugin Contributor dudo

    (@dudo)

    2 years, 8 months ago

    Version 2.8.5 was just released, can you please try and let me know?

    danigomu

    (@danigomu)

    2 years, 8 months ago

    Hi Dario,

    I just upgraded to version 2.8.5 and have run some speed tests with Lighthouse. In the benchmarks there seems to be no trace of the react-dom.min.js, good job.

    Thank you!

Viewing 15 replies - 1 through 15 (of 16 total)
1 2
  • The topic ‘Remove unused JS from react-dom’ is closed to new replies.