Support » Plugin: Simply Static » relative url no longer replaced for wpemojiSettings

relative url no longer replaced for wpemojiSettings

  • Resolved tremlas

    (@tremlas)


    1 year ago

    Having installed the latest version (2.1.6) and regenerating my site I see that the url for the wpemojiSetting javascript variable is no longer replaced by a relative version. So, for example, I see the following change (and only this change) on my pages that should have been left unchanged:

    13 -window._wpemojiSettings = {“baseUrl”:”https:\/\/s.w.org\/images\/core\/emoji\/14.0.0\/72×72\/”,”ext”:”.png”,”svgUrl”:”https:\/\/s.w.org\/images\/core\/emoji\/14.0.0\/svg\/”,”svgExt”:”.svg”,”source”:{“concatemoji”:”\/wp-includes\/js\/wp-emoji-release.min.js?ver=b3e6d3e3cd4a5a4f085291e58c9b98b3″}};
    13 +window._wpemojiSettings = {“baseUrl”:”https:\/\/s.w.org\/images\/core\/emoji\/14.0.0\/72×72\/”,”ext”:”.png”,”svgUrl”:”https:\/\/s.w.org\/images\/core\/emoji\/14.0.0\/svg\/”,”svgExt”:”.svg”,”source”:{“concatemoji”:”http:\/\/virtual.internal\/wp-includes\/js\/wp-emoji-release.min.js?ver=b3e6d3e3cd4a5a4f085291e58c9b98b3″}};`

    (the ‘-‘ version is the before version, the ‘+’ version is the new version where “http:\/\/virtual.internal” is now not removed from the concatemoji url)

Viewing 5 replies - 1 through 5 (of 5 total)
  • zenichro

    (@zenichro)

    1 year ago

    Same problem here

    after plugin update,

    window._wpemojiSettings = {"baseUrl": -( ommit )- ,"source":{"concatemoji":"https:\/\/xxxxx.zenich.com\/wordpress\/wp-includes\/js\/wp-emoji-release.min.js?ver=6.0.2"}};

    before update;

    window._wpemojiSettings = {"baseUrl": -( ommit )- ,"source":{"concatemoji":"\/wp-includes\/js\/wp-emoji-release.min.js?ver=6.0.2"}};

    • This reply was modified 1 year ago by zenichro.
    Plugin Author patrickposner

    (@patrickposner)

    1 year ago

    Hey @tremlas and @zenichro,

    thanks for your error reports.

    That may result from removing the catch-all replacement rule from Simply Static within the latest update.

    Simply Static will instead use and extend the match_tags list now to replace URLs in a more controlled way and to make it possible to exclude specific tags from the replacement.

    However, I added the case as a GitHub issue here now: https://github.com/patrickposner/simply-static/issues/48

    I plan to improve the URL replacements within script tags and JSON within the next update.

    Best regards,
    Patrick

    Thread Starter tremlas

    (@tremlas)

    1 year ago

    I can do a test on my site if you would like a level of system test on the next version – I’ll be staying on 2.1.5.6 until then 🙂

    Plugin Author patrickposner

    (@patrickposner)

    1 year ago

    Hey @tremlas,

    update is out now!

    Thread Starter tremlas

    (@tremlas)

    1 year ago

    Updated and this fixes my wpemojiSettings.

    I do note from the diff’s of the resulting statically pages that Simply Static now deletes the line break following a script tag (and from the corresponding end tag) – that doesn’t break the resulting page (at least for my use case) but is a change on the output page.

    In any event thanks for the update!

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘relative url no longer replaced for wpemojiSettings’ is closed to new replies.

Views