QM shows 1 PHP warning and 2 HTTP API call problems while using WP_HTTP_BLOCK_EX

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author John Blackbourn

    (@johnbillion)

    WordPress Core Developer

    4 years, 10 months ago

    Thanks for the report.

    Unfortunately there are a few places in the HTTP API in WordPress which don’t provide actions or filters for QM to hook into. One of these is the return value on the WP_Http::request() method when it returns an error due to, among other things, the WP_HTTP_BLOCK_EXTERNAL constant being in use.

    In this situation, QM has to assume that the request timed out because it can’t access the actual error message.

    I’m going to open a WordPress core bug report to get the required actions or filters added to that class so QM can correctly report the error message.

    On my local development environments I’m a big fan of using Airplane Mode to block external HTTP requests and external assets. Give it a try, it might work better than using the WP_HTTP_BLOCK_EXTERNAL constant.

    Plugin Author John Blackbourn

    (@johnbillion)

    WordPress Core Developer

    4 years, 10 months ago

    Oh! It turns out I already reported this bug six years ago haha. https://core.trac.wordpress.org/ticket/25747

    I’ll see if I can get it moving.

    Thread Starter tahtu

    (@tahtu)

    4 years, 10 months ago

    I aggree with you: It was a mistake to bother you with this issue. WP has to fix it.

    Sorry!

    Thread Starter tahtu

    (@tahtu)

    4 years, 10 months ago

    I have an idea, how you could serve me and improve the QM:

    Implement a feature to hide errors, warnings and hint.

    Like mentioned before in this topic, I get always a special problem inside the admin panel. QM shows me located here:
    wp-includes/update.php:155

    Like mentioned before by you, this is a problem of WordPress, which you still reported several years before. So there is not a lot of hope to, that it will be fixed soon.

    But you could let me accept and hide this error and not show it to me again later on.

    Right now, I have a second problem: A warning about “compact(): Undefined variable: groupby” in wp-includes/class-wp-comment-query.php:853. Without analyzing this problem further more, I believe it could be a problem of WordPress too. (But maybe it based on a problem from me, I know. 😉 )

    So if I could mark that problem as accepted, I would not longer see the QM area inside the admin bar highlighted. So I would detect new problems better, since right now, I have to search from them. They are not show to me otherwise.

    … just my idea, I wanted to share with you…

    • This reply was modified 4 years, 10 months ago by tahtu.
    Thread Starter tahtu

    (@tahtu)

    4 years, 10 months ago

    … ah, I found the reason, why WordPress shows the update problem warning to me:

    function nw_pre_site_transient_update_core() {
    return NULL;
    }
    add_filter(‘pre_site_transient_update_core’, ‘nw_pre_site_transient_update_core’);

    … the result must be false instead of null.

    So right now, I don’t see the QM area inside the admin bar highlighted further more.

    But the idea with accepting and hiding problems is still not bad, I believe. Maybe other developer have problems…

    Plugin Author John Blackbourn

    (@johnbillion)

    WordPress Core Developer

    4 years, 10 months ago

    You can already hide errors from plugins and themes that you choose. Instructions here: https://querymonitor.com/blog/2018/07/silencing-errors-from-plugins-and-themes/

    QM should be automatically hiding the “An unexpected error occurred” warning that WordPress core generates, it seems like it’s not doing it at the moment so I’ll get that fixed.

    Thread Starter tahtu

    (@tahtu)

    4 years, 10 months ago

    You have a lot of great knowledge. But it’s not easy to me to find them by myself. Maybe you could think about, how you could offer this knowledge more easily to people like me? …

    Thank’s alot for this filter!

    Thread Starter tahtu

    (@tahtu)

    4 years, 10 months ago

    Right now, I tried to implement the hiding solution for the problems. While doing this, I missed a feature to hide special bugs of the WordPress core. Exactly still a problem in “wp-includes/update.php:155”.

    Am I right, there is no filter which I can use to hide this bug only?

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘QM shows 1 PHP warning and 2 HTTP API call problems while using WP_HTTP_BLOCK_EX’ is closed to new replies.