Product gallery videos broken due to plugin conflict

  • Resolved SiteBolts

    (@sitebolts)


    1 year, 5 months ago

    Hi there, we’re trying this plugin out on a development site but can’t get the YouTube videos to work.

    Whenever we try a YouTube URL like https://www.youtube.com/watch?v=jNQXAC9IVRw or https://www.youtube.com/embed/jNQXAC9IVRw , it breaks all of the gallery images on the page and throws this JavaScript error:

    Uncaught TypeError: Failed to construct 'URL': Invalid URL
    at getParameterByName (admin.min.js?ver=3.8.4:1:54)
    at HTMLIFrameElement.<anonymous> (nickx.front.js?ver=1.4.1.5:134:16)
    at Function.each (jquery.min.js?ver=3.6.3:2:3003)
    at e.<computed>.each (jquery.min.js?ver=3.6.3:2:1481)
    at HTMLDocument.<anonymous> (nickx.front.js?ver=1.4.1.5:130:34)
    at e (jquery.min.js?ver=3.6.3:2:30158)
    at t (jquery.min.js?ver=3.6.3:2:30460)

    Looking at the values in the breakpoint, it appears that the URL function is being passed the hardcoded string “start” rather than the YouTube URL, which I assume is a coding mistake.

    • This topic was modified 1 year, 5 months ago by SiteBolts.
Viewing 5 replies - 1 through 5 (of 5 total)
  • Thread Starter SiteBolts

    (@sitebolts)

    1 year, 5 months ago

    Actually, I just noticed that the getParameterByName function is being created by Happy Addons for Elementor, but called by this plugin.

    I’m guessing that this might be a function name conflict caused by both plugins trying to create a non-identical function with the same name.

    To avoid that, it’s usually best to either use class functions or prefix your global function names with a unique string to be something like progalvGetParameterByName().

    A fix would be appreciated since we rely on Happy Addons for Elementor (along with 300,000 other people, according to its plugin page stats) and can’t currently launch our site with this plugin active.

    • This reply was modified 1 year, 5 months ago by SiteBolts.
    Thread Starter SiteBolts

    (@sitebolts)

    1 year, 5 months ago

    I just deactivated Happy Elementor Addons and that fixed the problem, which confirms that the function name conflict is to blame.

    Ideally both plugins should rename their function or move it to a class.

    Plugin Author NikHiL Gadhiya

    (@nikhilgadhiya)

    1 year, 5 months ago

    Hello @sitebolts,
    We’ll fix this issue and release the update ASAP.

    Thank You.

    Plugin Author NikHiL Gadhiya

    (@nikhilgadhiya)

    1 year, 4 months ago

    Hello,

    I’ve fixed this issue and released an update. Please update the plugin with the latest version.

    Thank You.

    Thread Starter SiteBolts

    (@sitebolts)

    1 year, 4 months ago

    @nikhilgadhiya – Thanks for the quick response. That seems to have fixed it.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Product gallery videos broken due to plugin conflict’ is closed to new replies.