Plugin Author
Eli
(@scheeeli)
Thank you for sharing your code. I wholeheartedly appreciate the need for the “empty with”. I had made that possible with the other shortcodes used for substitutions but somehow overlooked it in the remote_get function.
I’m not sure about the use of html_entity_decode in the str_replace but I can see how it improves the url parameter in the remote_get function, although I have been able to pass parameters within the url on my remote_get attempts without this html_entity_decode addition.
I wonder what your thoughts are on the use of html_entity_decode on the first two parameters of the str_replace function. Wouldn’t that negate your search for the encoded characters in the content? And what if it was the encoded characters that you wanted to use in your substitution? I have had a lot of difficulty using HTML in the parameters of a shortcode, not because they get encoded, but because the WP content engine decides to insert line breaks into what it perceives as HTML. This has been quite a personal nuisance to me but I have always managed to get it to work, sometimes by using encoded HTML to fool the content formatting engine.
Plugin Author
Eli
(@scheeeli)
Hey pietma,
I fixed these bug in my latest release. Do you want to take a look and see how that works for you?
Any more feedback on this is welcome.
Aloha, Eli