• Resolved margr

    (@mar1984)


    Hello,

    I have created a Kadence Fluid carousel Gallery, which opens the images in Lightboxes. I need some of those images to go externally to another page, so I thought of adding a link in the caption of the image with the code <a href="" target="_blank">TEXT</a>.

    [Issue] In the thumbnail carousel the images are displayed correctly and the link is visible at the bottom of the image. However when I click to view it in lightbox: the linked captions lose the link and only the text is displayed. Also, images that have links as captions are duplicated in the lightbox carousel.

    [Request] Regarding the request (I don’t know if there is a specific section for it), it is related to the problem of losing the links in the Lightbox:

    Can you add the tag ‘a’ for the links in the lightbox captions?

    I was checking your code in case I could do it myself through some filter, but I only found ‘kadence_blocks_pro_dynamic_gallery_caption’ which is applied before.

    I found that on line 769 of class-kadence-blocks-advancedgallery-block.php there is a call to ‘strip_tags( html_entity_decode($caption, ENT_QUOTES, ‘UTF-8’) )’ with no tags arguments allowed. It would be interesting if you could include link tag as a second argument:

    $allowed_tags = '<a>';
    
    [...] (Line 769) 
    
    if ( ! empty( $href ) ) {
    	$output .= '<a href="' . esc_url( $href ) . '"' . ( $link_to === 'media' && $lightbox === 'magnific' && $lightbox_cap && ! empty( $caption ) && is_string( $caption ) ? ' data-description="' . esc_attr( strip_tags( html_entity_decode($caption, ENT_QUOTES, 'UTF-8'), $allowed_tags ) ) . '"' : '' ) . '' . ( $link_to === 'media' && $lightbox === 'magnific' && ! empty( $image_alt ) && is_string( $image_alt ) ? ' data-alt="' . esc_attr( $image_alt ) . '"' : '' ) . ' class="kb-gallery-item-link" ' . ( ( $link_to === 'custom' && '_blank' === $link_target ) || ( $link_to === 'media' && $lightbox === 'new_tab' ) ? 'target="_blank"' : '' ) . ' ' . ( ( $link_to === 'custom' && ! empty( $rel_attr ) ) || ( $link_to === 'media' && ! empty( $rel_attr ) ) ? 'rel="' . esc_attr( $rel_attr ) . '"' : '' ) . '>';
    }	
    

    Also the ‘strong’ tag for bold would be interesting.

    As for the image duplication problem when opening in Lightbox images with links in caption I haven’t found yet in the code what might be happening.

    Thanks for your work on this very complete plugin.

    I look forward to your reply, thank you very much in advance.

    P.S.: I don’t know if I posted in the right place, initial post here: Initial post in Github

    Best regards,
    Marina.

Viewing 13 replies - 1 through 13 (of 13 total)
  • Plugin Support Bonn

    (@bonnlevelup)

    Hi there,

    Thanks for the request.

    I will forward this to our development team.

    Let me know if there’s anything else we can help you with.

    Thread Starter margr

    (@mar1984)

    Hi,

    Thanks for passing it on to the development team, I hope they find it useful and approve its inclusion.

    My problem is precisely because when I put a link in the image caption the slide comes out double in the carousel in full screen, if there is any way to solve it.

    [Issue] In the thumbnail carousel the images are displayed correctly and the link is visible at the bottom of the image. However when I click to view it in lightbox: the linked captions lose the link and only the text is displayed. Also, images that have links as captions are duplicated in the lightbox carousel.

    Plugin Support michael-levelup

    (@michaeltarongoy)

    Hi there,

    Currently, this is escalated to the development team via our internal issue tracker. We have no new update as of the moment. We will send you an update once we learn more.

    We appreciate your continued patience and understanding regarding this matter.

    Kind Regards,
    Michael Taro

    Thread Starter margr

    (@mar1984)

    Hello,

    Thank you, I look forward to hearing from you.

    Best regards,
    Marina

    Plugin Support michael-levelup

    (@michaeltarongoy)

    Hi there,

    Just a quick update.

    This has been added to the upcoming development sprint. That doesn’t mean it will be finished and the update will be released once the development sprint ends though.

    Please note that the actual timing is still subject to change.

    We appreciate your continued patience and understanding regarding this matter.

    Kind Regards,
    Michael Taro

    Thread Starter margr

    (@mar1984)

    Hi Michael,

    Thank you very much for the update, I understand the development timing.

    I remain on standby.

    Kind regards,
    Marina

    Thread Starter margr

    (@mar1984)

    Hi there,

    I just saw that the latest update (3.3.7) shows the links in caption in the lightboxes of the galleries. Thank you very much!

    On the other hand I still have the behaviour that the images that have links as caption in the gallery, shows double when opening the gallery in lightbox. Can you confirm me if this is something that is happening?

    Kind regards,
    Marina

    Plugin Support karlalevelup

    (@karlalevelup)

    Hi there!

    Kadence Blocks 3.4.9 doesn’t show doubled links: https://share.zight.com/xQukmvp9

    I’ll mark this topic as solved since the original issue was resolved already. Don’t hesitate to submit a new on if we can help you with anything else.

    Thread Starter margr

    (@mar1984)

    Hello @karlalevelup,

    Thanks for your reply. Sorry for my bad English, I will try to explain myself better.

    When I put a link in the caption and open the gallery in Lightbox, the link and the image are displayed correctly, they are not repeated. However, when I press the arrow to go to the next image, I get again the same image that has the link, ie: this image appears twice in the gallery lightbox. When I click on the arrow again, it goes to the next image. I hope I have explained myself better now.

    Kind regards,
    Marina

    Plugin Support karlalevelup

    (@karlalevelup)

    Hi, Marina!

    No worries and thanks for giving more details.

    Here’s a video of my replication: https://share.zight.com/qGu48LKJ

    The issue didn’t happen for me.

    Please let me know if I missed some replication steps. If not, could you give a page URL where I can see the issue happening?

    Thread Starter margr

    (@mar1984)

    Hi @karlalevelup,

    Thank you very much for your video and sorry for the delay in my reply.

    I have tried to replicate your steps on the site, set the default theme, deactivate plugins but I still have the problem. How can I pass you a private link with the website and login details? It is hidden as it is a test site.

    I look forward to hearing from you.

    Best regards,
    Marina

    Plugin Support karlalevelup

    (@karlalevelup)

    Hi, Marina!

    Sharing login links are not allowed in the forums (guidelines here).

    You can share a screen recording using a free tool like Zight so we could see how the issue happens for you.

    Thread Starter margr

    (@mar1984)

    Hi!

    Thank you very much @karlalevelup for the answers and for your time. The problem has disappeared with the installation of the latest version of Kadence blocks along with the upgrade to WordPress 6.8 and the update of the theme we are using. I can’t specify more where the error was, maybe at some point all three things were not working well, but now I can mark the thread as resolved.

    Best regards.

Viewing 13 replies - 1 through 13 (of 13 total)
  • You must be logged in to reply to this topic.