Support » Plugin: WP w3all phpBB » Problem using iframe feature with https

  • Resolved tlagren

    (@tlagren)


    Hi, I have been using the iframe feature which has been working great, but now when I have enabled SSL on my website I cannot load the forum in the iframe anymore. Everything worked well with plain http.

    This is what I did:
    – Enable Let’s Encrypt SSL feature frommy web hosting company
    – Changed the WP Setting about URL to the new https url
    – Changed the url to https in the w3all settings in WP
    – Changed from http:// to https:// in phpBB Admin Server settings
    – Updated the links in overall_footer.html so they use https instead of http
    – Enabled recompile in phpBB and loaded the forum from the direct link

    The forum is working without the iframe at https://wp2.transamclub.se/phpBB3

    Have I missed something?

    Update: I’m using the latest version of your plugin.

    /Tomas

    • This topic was modified 2 years, 11 months ago by tlagren.
    • This topic was modified 2 years, 11 months ago by tlagren.

    The page I need help with: [log in to see the link]

Viewing 7 replies - 31 through 37 (of 37 total)
  • Plugin Author axew3

    (@axewww)

    P.s check well v3 code that has been updated until yesterday to have ever all correct results and no problems!

    You had not add the overall_header code also i saw last time.
    Read all page until bottom and inline code hints if missed!

    ah yes … do not forget the pain in the a** to report just in case any news!

    • This reply was modified 2 years, 11 months ago by axew3.
    Plugin Author axew3

    (@axewww)

    // Fix by @tlagren
    // bug -> https://wordpress.org/support/topic/problem-using-iframe-feature-with-https/
    $w3all_url_to_cms .= (substr($w3all_url_to_cms, -1) == '/' ? '' : '/index.php');

    the file
    /wp-content/plugins/wp-w3all-phpbb-integration/addons/page-forum.php
    has been patched on repository.
    Cheers!

    Thread Starter tlagren

    (@tlagren)

    Ahh, I missed that part about overall_header but have implemented it now and removed a code block from footer as the instruction says and it seems to be working fine.

    Regarding the HTTP 301, I still think this is correct. I have tested it on several installations and they all do the same. I did also verify this against w3.org’s own website and they also do a redirect if you request a directory without adding the trailing slash.

    [tomas@goofy ~]$ curl https://www.w3.org/standards
    <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
    <html><head>
    <title>301 Moved Permanently</title>
    </head><body>
    <h1>Moved Permanently</h1>
    <p>The document has moved <a href="https://www.w3.org/standards/">here</a>.</p>
    </body></html>
    [tomas@goofy ~]$ 
    [tomas@goofy ~]$ 
    [tomas@goofy ~]$ curl -I https://www.w3.org/standards
    HTTP/2 301 
    date: Sun, 06 Jan 2019 17:24:49 GMT
    location: https://www.w3.org/standards/
    cache-control: max-age=21600
    expires: Sun, 06 Jan 2019 23:24:49 GMT
    content-type: text/html; charset=iso-8859-1
    strict-transport-security: max-age=15552000; includeSubdomains; preload
    content-security-policy: upgrade-insecure-requests

    /Tomas

    Plugin Author axew3

    (@axewww)

    Hi there! Hello Tomas
    I’m go to apply something into a site and i see that there is still a little problem on code:
    on this actual fix, after applied overall_header.html code, when you right/click/open new tab/window (and only on right click) to open a link like FAQ link, the code will fail because:
    the code will append index.php and the url will become something like this:
    https://192.168.1.5/forum/app.php/help/faq/index.php
    and with index.php appended in this kind of url phpBB will answer page not found.
    To avoid this (maybe this code can be better but actually work without big changes) the code should be changed into this:

    if( strlen($w3all_url_to_cms) == strlen(get_option( 'w3all_url_to_cms' )) OR strlen($w3all_url_to_cms) == strlen(get_option( 'w3all_url_to_cms' )) + 1 )
    {
    // Fix by @tlagren
    // bug -> https://wordpress.org/support/topic/problem-using-iframe-feature-with-https/
    $w3all_url_to_cms .= (substr($w3all_url_to_cms, -1) == '/' ? '' : '/index.php');
    }

    now should be any kind of passed url compatible and when FAQ like (app) links passed, the result will be fine. The fix has been committed on repo for the file page-forum.php
    Cheers!

    • This reply was modified 2 years, 11 months ago by axew3.
    Thread Starter tlagren

    (@tlagren)

    Aah, I didn’t test the fix so much and we haven’t moved over all real users to this yet so I didn’t see that.

    I added your new code and that seems to work, good job!

    /Tomas

    Plugin Author axew3

    (@axewww)

    ehm and … yes forced because the site need to be perfect for tomorrow …
    this forum have many posts, so i’ve see that this line on overall_footer.html
    if ( href.charAt(0) == '#' && href.length == 1 || /^#[a-z0-9]+$/ig.exec(href) !== null && href.length < 8 ){
    need to be changed (what the hell i added the rest i do not really know now) into this instead:
    if ( href.charAt(0) == '#' && href.length == 1 || /^#[a-z0-9]+$/ig.exec(href) !== null){
    because certain links on forum viewtopic are in this way:
    #p1707780
    and these are more then 8 chars in this case.
    Just some finishing touch!

    Plugin Author axew3

    (@axewww)

    but the best way may is to use only this maybe:
    if ( href.charAt(0) == '#' ){
    if no problems to report on next tests the line will be switched to this

Viewing 7 replies - 31 through 37 (of 37 total)
  • The topic ‘Problem using iframe feature with https’ is closed to new replies.