Support » Plugin: WP Super Cache » print_r() debug messages break pages with query args

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Donncha O Caoimh

    (@donncha)

    Thanks for the report. What error message do you see?

    PHP Fatal error: print_r(): Cannot use output buffering in output buffering display handlers in /…/wp-content/plugins/wp-super-cache/wp-cache-phase2.php on line 253

    cheers,
    Ross

    Plugin Author Donncha O Caoimh

    (@donncha)

    Thanks for that. I’ve just checked in a fix, using serialize like you did and giving you props in the checkin message. I’ll mention your WordPress.org username in the readme.txt too.

    G’day Donncha,

    Thanks, will settle the restless natives I reckon 🙂

    NB: you’ve made a change to wp_cache_debug() that isn’t correct. You’re now logging $message, which is the message passed into the function. Should instead fix the typo $log_messase as per this PR (commit).

    cheers,
    Ross

    Plugin Author Brandon Kraft

    (@kraftbj)

    Code Wrangler

    Hi Ross,

    Donncha committed the typo fix. For next time, the best practice on git PRs is to create a new branch for each fix you’re wanting to propose (e.g. git checkout -b fix-message-typo).

    This is good for a few reasons
    1. Your master branch stays accurate to the main repo’s master branch to help in future PRs.
    2. In this case, the typo wasn’t reviewed/committed since it was part of a bigger PR that hasn’t been reviewed yet. It’s pretty easy to merge the entire PR, but enough additional work to merge an additional commit that, generally speaking, doesn’t happen.

    More atomic PRs helps reduce the review burden, increasing the likelihood of a merge, while reducing the time it takes to do so. I appreciate the PR and will have it reviewed ASAP.

    We’re trying to train up some additional folks on WPSC so Donncha doesn’t have to bear the whole burden and been held back by a couple of unrelated things (both personal… having babies and whatnot, and within the company).

    Thanks for your understanding!

    G’day @kraftbj,

    Are you talking about the “fixed typo” PR by ctimoteo, or my “only preload public posts” PR? I think you’ll find that my PRs are created on new branches, not on master. Maybe you’re confused about who created the “fixed typo” PR.

    Congrats to @donncha on having babies, quite an achievement for a bloke 🙂

    cheers,
    Ross

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘print_r() debug messages break pages with query args’ is closed to new replies.