Possible bug in parallax code

  • aradams

    (@aradams)


    8 years, 5 months ago

    I’m using Harmonic to develop another theme, and I came across something that I think might be a bug. When scrolling the Font Page parallax page, the “News” section text flashes in a distracting way. None of the other sections do this. I took a look at the content-front-news.php template and noticed these lines:

    <div class="hsContent"
data-center="opacity: 1"
data-center-top="opacity: 0"
data--100-bottom="opacity: 0;"
data-anchor-target="#slide-2">

    The other templates have this code: 

    <div class="hsContent"
data-center="opacity: 1"
data-center-top="opacity: 1"
data--100-bottom="opacity: 1;"
data-anchor-target="#slide-[]">

    When I changed the opacity numbers to 1 in content-front-news.php the flashing went away. I think these opacity setting should all be the same, for a consistent user experience. Thanks!

Viewing 9 replies - 1 through 9 (of 9 total)
  • Moderator Kathryn Presner

    (@zoonini)

    8 years, 5 months ago

    Hi there, thanks for pointing this out! Harmonic is supposed to fade in the News section and then gradually fade it out, but it looks like something isn’t working quite right. I’m going to ask our theme developers to take a look, thanks for passing along your proposed fix. We’ll keep you posted here.

    Thread Starter aradams

    (@aradams)

    8 years, 5 months ago

    Thanks Kathryn. If the News section is supposed to fade in/out on scroll, then shouldn’t the other sections do the same? IMHO it doesn’t make sense to just have that behavior on one section only. Thanks for passing this along 😉

    Moderator Kathryn Presner

    (@zoonini)

    8 years, 5 months ago

    It was a design decision to do it that way. If you prefer not to have the fading, you can always override it in a child theme, though! Or since you mentioned you’re developing “another theme” you’re forking Harmonic?

    Using a child theme means your tweaks won’t be overwritten when updating the theme. Here are some guides in case you haven’t made one before:

    http://codex.wordpress.org/Child_Themes
    http://op111.net/53/

    Thread Starter aradams

    (@aradams)

    8 years, 5 months ago

    Thanks for the Child Theme info. I’ve decided not to do that with this project, as there is too much I want to change. I am Frankensteining several themes into one scary new beast 😉

    Moderator Kathryn Presner

    (@zoonini)

    8 years, 5 months ago

    Good luck with your new monster, sounds scary and exciting! 😉

    Thread Starter aradams

    (@aradams)

    8 years, 5 months ago

    Thanks! The primary mod I am working on right now is changing the front page template to display featured pages, rather than the current options of news, page, widget, and portfolio. I have successfully integrated the Featured Pages code from Edin into the Customizer and, so far so good 😉

    It’s primarily the difficulty of overriding the customizer template that has set me to fork Harmonic. I am probably missing something, but forking seems the best way to go at this point.

    Moderator Kathryn Presner

    (@zoonini)

    8 years, 5 months ago

    Yep, Harmonic is a bit of a complex theme so making substantial structural changes in a child theme is not simple and in some cases, just not feasible. I don’t think you’re missing anything. 🙂

    Thread Starter aradams

    (@aradams)

    8 years, 4 months ago

    Hi Kathryn,

    A follow-up with some more errors I’m noticing in this theme.

    • In the Clearings section of style.css, there are references to .site-header, but that class does not exist in the header templates. Looking at Twenty Fifteen I see that the #masthead carries this class, but no in Harmonic.
    • In the Clearings section of style.css, there are references to .site-content, but that class does not exist in the templates. Looking at Twenty Thirteen I see the #content div carries this class, but in Twenty Fifteen and beyond this class has been changed to .site-main. (Twenty Fifteen’s stylesheet has this error too, and is referenced in footer.php.)
    • There are a couple of <div class=”clear”></div> tags… I thought we were done with this technique… why aren’t elements being cleared the right way?

    There are also several errors in the template descriptions–not a bit deal unless someone is trying to make a child theme, but rather sloppy nonetheless.

    Moderator Kathryn Presner

    (@zoonini)

    8 years, 4 months ago

    Thanks for the reports on those issues you noticed – I’ll pass them along to our developers so they can have a look.

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘Possible bug in parallax code’ is closed to new replies.