possibility of orphaned comment in listmarker script

  • Resolved heredatedwp

    (@heredatedwp)


    1 year, 9 months ago

    Hello,

    I am doing some changes below shortcode of leaflet map and they are not working, but they were working some days ago.

    After some debugging I realize a possible problem with a comment tag in listmarker.
    when I add:
    [listmarker update=false overiconurl= hover]
    a new script is added to the html:

    <script><!–
    window.WPLeafletMapPlugin=window.WPLeafletMapPlugin||[];window.WPLeafletMapPlugin.push(function(){let propertyName=””;let overiconurl=””;let collapse=false;let update=false;let hover=true;let highlight=”rgba(255, 255, 255, 0.8)”;let maxheight=0.69999999999999996;let maxwidth=0.5;leafext_listmarker_js(propertyName,overiconurl,collapse,update,hover,highlight,maxheight,maxwidth);});</script>

    As you can see, there is a open comment tag, but there is no tag to close it.

    when I remove the listmarker tag the code below shortcode start working again, so I assume it’s the problem of that comment tag.

    Thank you for your plugin.


Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author hupe13

    (@hupe13)

    1 year, 9 months ago

    There is a bug in listmarker script if overiconurl is empty, I fixed it in the Github version. Today in the afternoon I will release the WordPress Version.

    Thread Starter heredatedwp

    (@heredatedwp)

    1 year, 9 months ago

    I’ve changed shortcode:

    [listmarker update=false hover]

    Now script is:
    <!–
    window.WPLeafletMapPlugin=window.WPLeafletMapPlugin||[];window.WPLeafletMapPlugin.push(function(){let propertyName=””;let overiconurl=”https:\/\/URL\/wp-content\/plugins\/extensions-leaflet-map\/pict\/marker-icon-red.png”;let collapse=false;let update=false;let hover=true;let highlight=”rgba(255, 255, 255, 0.8)”;let maxheight=0.69999999999999996;let maxwidth=0.5;leafext_listmarker_js(propertyName,overiconurl,collapse,update,hover,highlight,maxheight,maxwidth);});

    But code below shortcode still doesn’t work.

    Will wait for fix on repo.
    Thank you.

    Plugin Author hupe13

    (@hupe13)

    1 year, 9 months ago

    Is the word <script> in front of <--? Do you have a link to a test page?

    Thread Starter heredatedwp

    (@heredatedwp)

    1 year, 9 months ago

    Can I send you a link in a email direction?

    Plugin Author hupe13

    (@hupe13)

    1 year, 9 months ago

    See here at the bottom.

    Plugin Author hupe13

    (@hupe13)

    1 year, 9 months ago

    It was a problem with SVG marker. Fixed in version 4.4.3.

Viewing 6 replies - 1 through 6 (of 6 total)

The topic ‘possibility of orphaned comment in listmarker script’ is closed to new replies.