Poor handling of window.scroll event listener!

  • Matt Keith

    (@grafikmatthew)


    9 years ago

    I’m currently using a theme that binds behaviors to the window.scroll event. I noticed that anything that related to these theme features broke the moment I hid the GC Message Bar. I tracked the problem down to the JS function closeMessageBar().

    The problem is that the addon elected to unbind ALL window.scroll event listeners by using the dangerous operation of:

    jQuery(window).unbind("scroll");
jQuery(window).scroll(GC.Sticky.Scroll);

    In a world where add-ons don’t automatically assume that their code is the only code that matters, these two lines would be better written as this instead:

    jQuery(window).one("scroll", GC.Sticky.Scroll);

    I’d like to continue using this add-on, as I find it to be extremely easy to use. Please fix ASAP, so I don’t have to run a forked version on client sites that elect to also use the add-on.

    https://wordpress.org/plugins/gc-message-bar/

  • The topic ‘Poor handling of window.scroll event listener!’ is closed to new replies.