WordPress.org

Support

Support » Plugins and Hacks » [Resolved] [Plugin: WP Stripe] httpss://

[Resolved] [Plugin: WP Stripe] httpss://

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Noel Tock
    Member

    @noel_tock

    Extra s, hmm weird 🙂 Will look, thanks for letting me know!

    Plugin Author Noel Tock
    Member

    @noel_tock

    Alrighty, I’m guessing you already have another plugin for this, my code is as follows:

    if ( $options['stripe_modal_ssl'] == 'Yes' ) {
            $path = str_replace("http", "https", $path, $count);
        }

    What that’s telling me is that the link already is https:// , so just disable the option.

    xhenxhe
    Member

    @xhenxhe

    Yeah, I fixed it by disabling the option, just thought it would be best to check first to avoid confusing. What if on some blogs the https is not required and a user could may or may not be using https?

    Perhaps you could change the code to:

    if ( $options['stripe_modal_ssl'] == 'Yes' && substr($path, 0, 5) != 'https' ) {
            $path = str_replace("http", "https", $path, $count);
        }
    Plugin Author Noel Tock
    Member

    @noel_tock

    Sure, but that’s sending the wrong impression too (i.e. that the user thinks he has and needs SSL enabled on the wp-stripe when they don’t, because another plugin already handles what not).

    xhenxhe
    Member

    @xhenxhe

    Doesn’t sent the wrong message. Works as designed (add https if options is selected) but fixes the bug so it doesn’t change the the url to httpss – making it unusable.

    Plugin Author Noel Tock
    Member

    @noel_tock

    We can agree to disagree, I feel I just need to add it to the description 🙂

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘[Resolved] [Plugin: WP Stripe] httpss://’ is closed to new replies.