[Plugin: WordPress Social Login] Error with Vkontakte provider
-
Hi, great plugin! thanks!
But I’ve found a few issues (In my opinion :))
I use 1.1.9
1. includes/plugin.auth.php
line 107: should be this check on empty($user_login), validate_username is true for empty.
2. hybridauth/Hybrid/Providers/Vkontakte.php
line 92: should be check if ‘nickname’ is not null, because in Vkontakte API this is nullable fileld. If nickname is null, displayName will be ‘first_name’ + ‘last_name’. But, pay attention, first_name and last_name can be in cyrillic.
3. includes/plugin.auth.php
If you update users metadata will be better to add something like that, for getting a friendly error messages.// update user metadata if( $user_id && is_integer( $user_id ) ){ update_user_meta( $user_id, $provider, $hybridauth_user_profile->identifier ); } else if (is_wp_error($user_id)) { echo $user_id->get_error_message(); } else{ die( "An error occurred while creating a new user!" ); }
Thank you, and sorry for my english)
Viewing 1 replies (of 1 total)
Viewing 1 replies (of 1 total)
- The topic ‘[Plugin: WordPress Social Login] Error with Vkontakte provider’ is closed to new replies.