Support » Plugin: Yoast SEO » [Plugin: WordPress SEO by Yoast] Turn php errors to E_ALL and fix notices and warnings please!

  • Resolved beetlefish

    (@beetlefish)


    Love your plugins – but I’m getting a lot of php error messages – granted not fatal. Please fix them.

    We have a zero tolerance for notices even if display errors is off. We have to fix your code before we deploy and we’d rather not touch the core of your plugin for better upgrades in the future.

    http://wordpress.org/extend/plugins/wordpress-seo/

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Joost de Valk

    (@joostdevalk)

    Dude, be more specific. My plugin currently throws no notices I’m aware of and I always have E_ALL on.

    Notice: Undefined index: fb_admins in /wp-content/plugins/wordpress-seo/admin/class-config.php on line 1172

    And we are still seeing a periodic undefined index from wp-content/plugins/wordpress-seo/frontend/class-frontend.php on line 361

    I believe the index is “link”. But it’s periodic so I can’t cut and paste it here.

    We already deployed your earlier upgrade to 1.1.6. We will deploy 1.1.7 tomorrow.

    Plugin Author Joost de Valk

    (@joostdevalk)

    That second one was fixed in 1.1.7 I think, just fixed the first one in trunk for the next release.

    Hello. Another one for you, in 1.1.7:

    Notice: Undefined index: metakey-page in plugins/wordpress-seo/frontend/class-frontend.php on line 511

    I think this is caused by the || operator taking precedence over the && isset() in the conditional on the previous line.

    Cheers

    Another one …

    Notice: Undefined variable: datestr in /wp-content/plugins/wordpress-seo/admin/class-metabox.php on line 437

    Plugin Author Joost de Valk

    (@joostdevalk)

    Thanks! Will fix both for 1.1.8

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘[Plugin: WordPress SEO by Yoast] Turn php errors to E_ALL and fix notices and warnings please!’ is closed to new replies.