Support » Plugin: PWA » Plugin Triggers “Navigation Preload Disabled”

  • Resolved jetxpert

    (@jetxpert)


    Hi there,

    After installing PWA 0.3.0, the following message is being triggered by WordPress’ Site Health Tool:

    A theme or a plugin appears to have disabled navigation preload in order to enable a navigation caching strategy. This was a workaround that is now no longer needed, and it is actually being ignored. Remove the following code from your theme/plugin to improve performance: add_filter( ‘wp_service_worker_navigation_preload’, ‘__return_false’ .

    For more info, click here: http://prntscr.com/oq34zf

    Above confirmed. When we deactivate your plugin (PWA), the warning disappears. Please advise. Thank you!

Viewing 9 replies - 1 through 9 (of 9 total)
  • Hi there (again),

    Found the line of codes related to the above in PWA’s “PWA.php” file. Interesting. Verbiage found in the php file is the same as the one provided by WordPress’ Health Check tool.

    Click here for details: http://prntscr.com/oq3d1j

    Please advise. Thank you.

    Plugin Author Weston Ruter

    (@westonruter)

    Yes, do you have a theme or plugin that is filtering wp_service_worker_navigation_preload to false?

    Hi Weston,

    I have no idea, but when I deactivate your plugin, the problem goes away. So, could it be yours?

    Otherwise, are you saying that your plugin is triggering the above WP Health Check tool message based on a theme or another plugin? Sorry, no clue or understanding of Service Workers, so wouldn’t know how to start troubleshooting the issue.

    The theme we use is Avada 6.0 (released just three days ago, August 5). They use your plugin (somewhat integrated into theirs), so perhaps it would be beneficial for you to reach out to them?

    Also, I have heard in the past that the WP Health Check tool could issue at times “false positives” that will drive developers nuts.

    Thank you!

    Plugin Author Weston Ruter

    (@westonruter)

    The PWA plugin intentionally includes this Health Check for navigation preload: https://github.com/xwp/pwa-wp/pull/178

    Navigation preload used to need to be disabled, but now it should be disabled no longer. So if Avada is indeed disabling it, they need to stop doing so.

    I am not a customer of Avada, so please reach out to them with the bug report.

    Hi Weston,

    Why did you mark this issue as resolved? It’s not. You added a code to your plugin that triggered the message.

    What is the benefit of it? Your code is creating a false positive, since the change is being ignored and not affecting our website performance. In fact, we’re not using the “Network-First or Stale-While-Revalidate” options in Avada and your message is still being triggered.

    Click here: http://prntscr.com/oqrlng

    I would like to recommend removing the affected code change you made. We didn’t have this issue with PWA 0.2.0. No message, no worries since everything is working in the backend.

    We prefer seeing other updates incorporated into your plugin and taking it out of beta.

    Other than that, great plugin for starters. Looking forward to the first official non-beta release.

    Thank you!

    Hi Weston (again),

    Oh, one other thing … your message is also asking most WordPress users to perform a task (plugin and theme troubleshooting, then deleting the code you mentioned) that goes well-beyond a non-developers knowledge. If you have any suggestions on how to do this (troubleshooting) easily, please let us know.

    Thank you!

    Plugin Author Weston Ruter

    (@westonruter)

    This is something that the theme developer needs to update. There isn’t anything to be done in the PWA plugin.

    I don’t have access to the theme in order to see what is going on, since it is a commercial theme. Thus please contact their support to troubleshoot the issue.

    I’ll happily re-open the issue if Avada says there is a bug. Otherwise they should update their theme to discontinue disabling navigation preload.

    Submitted the following to Avada:

    https://theme-fusion.com/forums/topic/avada-pwa-plugin-issues/

    Stay tuned for their response.

    Cheers!

    jetxpert

    (@jetxpert)

    @westonruter,

    Issued solved with the recent release of Avada 6.0.2.

    The following code was added to the file “class-avada-pwa.php” :

    // This filter is not necessary in PWA plugin versions greater than 0.3.
    		// If site is using an older PWA version add the filter.
    		if ( ! defined( 'PWA_VERSION' ) || version_compare( PWA_VERSION, '0.3.0' ) < 0 ) {
    			add_filter( 'wp_service_worker_navigation_preload', '__return_false' );
    		}
    
    		// Add theme-support for theme-color.
    		$this->add_theme_supports();

    Cheers!

Viewing 9 replies - 1 through 9 (of 9 total)
  • You must be logged in to reply to this topic.