ThickBox Content
[resolved] Suggestion for update (3 posts)

  1. istarnet
    Posted 5 years ago #

    The problem is that you cannot add querystring arguments to a url when creating a link to thickbox content. This is because the plugin *always* postpends ?keepThis=true&more=args.

    I solved this by adding this code after line 61 of lib/shortcodes.php

    // istarnet.com: inline href strings might contain querystring arguments.
    // If the $url contains a ? then postpend with a &
    if (strpos($url,'?')) {$conjunctive = '&'; } else { $conjunctive = '?'; }

    Then I changed (former line 61, now line 65 to:

    $out = $opentag . '<a' . $hid . $class . ' href="' . $url . $conjunctive . 'keepThis=true'.$iframe.'&height=' . $height . '&width=' . $width .'" title="' . $title . '" class="thickbox">' . $anchortext .'</a>' . $closetag;

    I suggest you add this or a more elegant solution and re-release.

    And of course, THANK YOU for this plugin. I always include it and train my clients to add their own thickbox content!

  2. Max Chirkov
    Plugin Author

    Posted 5 years ago #

    Yes, looks like I totally "ignored" people that don't use permalinks :) Thanks for pointing that out. I'll include your patch into the next update. Thanks again!

  3. Max Chirkov
    Plugin Author

    Posted 5 years ago #

    Committed and released. Thanks!

Topic Closed

This topic has been closed to new replies.

About this Plugin

  • ThickBox Content
  • Frequently Asked Questions
  • Support Threads
  • Reviews

About this Topic