Support » Plugin: WordPress Comments Fields » Plugin still kills CLI execution

  • This issue has been mentioned previously on these two topics:
    https://wordpress.org/support/topic/reen-reen-bump-not-found-classes-input-class-php/
    https://wordpress.org/support/topic/reen-reen-bumps/

    Unfortunately the issue is still present despite suggestions it has been fixed.

    For example, this is the output of WP CLI with the most recent version (1.6) of the plugin:

    $ wp help
    Reen, Reen, BUMP! not found /classes/input.class.php

    Here’s the offending code:

    if (file_exists ( $_inputs ))
    	include_once ($_inputs);
    else
    	die ( 'Reen, Reen, BUMP! not found ' . $_inputs );

    The plugin shouldn’t really be using die() anyway – that’s a very destructive action. Instead, the hook involved should simply return, finishing the plugin execution but allowing WordPress to continue doing it’s thing. Here’s what I changed the code to:

    if (file_exists ( $_inputs ))
    	include_once ($_inputs);
    else
    	return;

    If this is acceptable is there any way it could make it’s way into a bugfix release please?

    Thanks!

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author N-Media

    (@nmedia)

    Hi @philipjohn,

    Sorry for the trouble. I am working on this and this will be fixed soon.

    Thread Starter Philip John

    (@philipjohn)

    Hiya,

    Any update on this?

    I noticed there are four places where there is a die() with this specific message. There are a bunch more uses of die() throughout the code which should be avoided as they could result in an unexplained WSOD for people.

    Thanks

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Plugin still kills CLI execution’ is closed to new replies.