Fancy Slideshows
[Plugin: Sponsors Slideshow Widget] [patch] typo and old code, still not working (6 posts)

  1. kbenoit
    Posted 4 years ago #

    [Code/diff moderated as per the Forum Rules. The maximum number of lines of code that you can post in these forums is ten lines. Please use the pastebin]

  2. lozkane
    Posted 4 years ago #

    Hi kbenoit, Could you please post code to pastebin or advise of the changes?

  3. kitchin
    Posted 4 years ago #

    I don't know what kbenoit posted, but I have a typo and old code fix proposal posted here: http://plugins.trac.wordpress.org/ticket/1526

    The typo is "$ths" for "$this".

    The old code's effect shows up when WP_DEBUG is true:

    Notice: register_uninstall_hook was called incorrectly. Only a static class method or function can be used in an uninstall hook. Please see Debugging in WordPress for more information. (This message was added in version 3.1.) in .../wp-includes/functions.php on line 3587

  4. kitchin
    Posted 4 years ago #

    I don't know who maintains this code, since http://plugins.trac.wordpress.org/changeset/297357 indicates the author is "stopping development" and moving the plugin URI from his/her own site to wordpress.org.

  5. kbenoit
    Posted 4 years ago #

    Here's the patch on pastebin:
    It fix the the typo mentioned by kitchin and a few more bugs.

  6. kitchin
    Posted 3 years ago #

    Pastebin not found, kbenoit.

    I've been looking at the CPU load since I noticed my laptop fan going full blast. By default jQuery updates every 13 ms. The load lasts longer on slow transitions. The load is higher if you have more than one widget in transition at the same time. Those can be nudged by changing the widget timeouts in Dashboard. But changing the 13 ms. requires some code. The simplest kludge is to insert this after each <script> in the PHP:
    jQuery.fx.interval = 200;
    NOTE: this will affect all jQuery animations.
    That's for a 200ms update interval. I'm experimenting with 50ms and it looks fine.

    I also have another typo fix, line 186:

    if ( !isset($instance['source']) || empty($instance['source']) ) {
    	$instance['source'] == 'links';
    	$link_category_display = 'block';

    Should be:

    if ( !isset($instance['source']) || empty($instance['source']) ) {
    	$instance['source'] = 'links';
    	$link_category_display = 'block';

Topic Closed

This topic has been closed to new replies.

About this Plugin

  • Fancy Slideshows
  • Frequently Asked Questions
  • Support Threads
  • Reviews

About this Topic