Support » Plugin: Polldaddy Polls & Ratings » [Plugin: Polldaddy Polls & Ratings] Extraneous br tag inserted before comment_text in ratings.ph

  • Resolved JeanPaulH

    (@djr)


    In polldaddy/ratings.php at line 24 an extra <br /> is inserted even if ratings for comments are disabled. I believe the condition for $rating_pos == 0 is wrong, but imho this filter (line 158) shouldn’t trigger anyway when ratings are disabled.

    http://wordpress.org/extend/plugins/polldaddy/

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Eoin Gallagher

    (@eoigal)

    Thanks djr, I have updated 2.0.15 to not include br tag if comments are disabled.

    I’m not sure about changing when to trigger the filter as if I include a lookup on comments option, it will be called on each page load whether there is comment text or not.

    I hope we’re talking about the same bug 🙂 I meant an extra <br /> is inserted in comment text, even though we disabled ratings for comments. You are saying “if comments are disabled”, but that’s not what I meant. We do have comments (so no comments disabled), we just don’t have comment ratings and therefore the plugin shouldn’t insert the extra <br />

    Thanks!

    Plugin Author Eoin Gallagher

    (@eoigal)

    Thanks djr, I believe we are talking about the same bug and a fix should be now included with 2.0.15. If you still see the br tag, remove the plugin, download it again and reinstall.

    Yes, you were right. Fixed in 2.0.15. Marked as Resolved.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘[Plugin: Polldaddy Polls & Ratings] Extraneous br tag inserted before comment_text in ratings.ph’ is closed to new replies.