Support » Plugin: Theme and plugin translation for Polylang (TTfP) » Plugin inside my theme mixing with my textdomain

  • Resolved Pavel Mares

    (@pavelmares)


    So we are loading ACF Pro inside our theme. When I select in TTfP settings my theme text domain “sikpre ( Theme Name: Šikmo premium – previo.cz , Text Domain: sikpre )” and save, in translations I also see ACF Pro strings as my textdomain “sikpre”.

    Is this correct behaviour?

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Marcin Kazmierski

    (@marcinkazmierski)

    Thread Starter Pavel Mares

    (@pavelmares)

    No, they are probably not. I wrote to second one just to be sure. For this one, it is that I have TWO different text-domains inside my theme because I am loading plugin (ACF) inside my theme.

    But in admin the acf string like __( ‘string from ACF’, ‘acf’ ); is appearing as __( ‘string from ACF’, ‘my-theme’ ); instead.

    Which I don’t think is correct.

    Plugin Author Marcin Kazmierski

    (@marcinkazmierski)

    I think it is the same issue:

    <?php print __( 'text' ); ?>
    <?php print __( 'text', 'twentytwenty' ); ?>
    <?php print __( 'text', 'my_theme' ); ?>
    <?php print __( 'text', 'acf' ); ?>

    if you translate “text” via Polylang, above each function will return the same translation, because Polylang plugin does not support domains in text translations from the admin panel (in my opinion).

    Thread Starter Pavel Mares

    (@pavelmares)

    I will try some tests on my own, but this was kinda bothering me. I have a way to fixed this issue for our use-cases (instead string like “search” we will use “SEARCH_FIELD_PLACEHOLDER”, which will avoid both of these issues + migrate the plugins out of the theme).

    Plugin Author Marcin Kazmierski

    (@marcinkazmierski)

    I understand your worries. It surprises me too. Also, I will try to look into this problem again at my free time.

Viewing 5 replies - 1 through 5 (of 5 total)
  • You must be logged in to reply to this topic.