Support » Plugin: Hammy » [Plugin: Hammy] Feedback? Bugs? Issues?

Viewing 15 replies - 1 through 15 (of 22 total)
  • Paul de Wouters

    (@pauldewouters)

    Human Made

    Hi Noel

    I found out about this plugin on the adaptive images website. Thanks for developing it.
    Will it work on a local install? I’m getting ‘undefined’ as the src value for the images, so just wondering if you’ve got it to work on a local install before investigating further

    thanks

    Plugin Author Noel Tock

    (@noel_tock)

    Hi Paul,

    Yep, had it going on local. Guessing your caching folder might be restricted?

    Paul de Wouters

    (@pauldewouters)

    Human Made

    thanks for the quick response.
    I’m having to work on a linux install, and struggling with permissions, so I’ll try to figure that out.

    Noel,

    This is a VERY sweet plugin. I have been searching for months for something like this!! Lightweight and user friendly.

    I am having trouble with borders and padding on the images. I tried using my own class and the figure.hammy-responsive with no luck. It adds the border, but not in the right places. Any suggestions?

    Plugin Author Noel Tock

    (@noel_tock)

    Sorry, Ive been running around and now here in SF. Need before and after screenshots to help out 🙂 Cheers!

    Hi there,
    The plugin works fine, just one little problem, when you add a link on the image, the link does not appear on the page. It’s in the HTML, we get a structure like this in HTML

    <a href="milink">
      <figure>
        <img> </img>
      </figure>
    </a>

    but in the DOM on Firebug (chrome and also Firefox) I get

    <p><a href="milink"></a></p>
      <figure>
        <img> </img>
      </figure>
    </a>

    and the link is not clicable. I tried to highlight the a tag, indeed it’s in the DOM before the figure element. Strange.

    Any idea how to fix it ?

    Hey, me again ^^

    As a matter of fact and 4 hours of investigation, the problem does not come frome the JavaScript, but from WordPress code cleanup (mess-up?). To put it simple, you can’t use a figure inside of a p element. The problem is that WordPress wrapes its images into p elements, so the outcome of the_content is
    <p> <a> <figure> </figure> </a> </p>
    This is not valid, and browser tend to do what they can with it, hence the strange behavior with the link.

    The solution we found (thanks kReEsTaL for some links) is to remove the p tag using regex. Maybe this could be added in the plugin for further release ?
    Here is a link with a regex that works and another one that works too

    Cheers 😉

    Plugin Author Noel Tock

    (@noel_tock)

    Hmm, thanks for hunting, I would have still expected the link to display, will review when I’m back from #wcsf. Appreciate the support!

    @noel Tock It’s the WordPress editor that messes things up. Also when you try to add the image in a paragraph, and align it left or right, the HTML gets reallt ugly and invalid.

    Plugin Author Noel Tock

    (@noel_tock)

    Haven’t forgotten about this! been a bit crazy with happytables, will get back to it soon enough 🙂

    Adam

    (@adamcole83)

    Perhaps I’m doing it wrong. It’s not working.

    I have the following:

    <article>
        <img>
        <aside>
            <!-- Content -->
        </aside>
    </article>

    I set the content container to be article and it’s not working.

    Plugin Author Noel Tock

    (@noel_tock)

    Is the image in your post/page or part of your theme?

    Adam

    (@adamcole83)

    It’s in my post/page. It’s the featured image.

    Plugin Author Noel Tock

    (@noel_tock)

    You have a live example somewhere?

    Adam

    (@adamcole83)

    No, I’m working locally. But the code is…

    <section class="main container">
    	<article id="post-42" class="">
    		<img width="851" height="450" src="rmi.jpg" class="attachment-post-thumbnail" />
    		<aside>
    
    		</aside>
    
    	</article>
    </section>
Viewing 15 replies - 1 through 15 (of 22 total)
  • The topic ‘[Plugin: Hammy] Feedback? Bugs? Issues?’ is closed to new replies.