hi @bphelp
Thanks for your feedback and nice review. I really need to update my config so that i don’t miss this kind of error 🙁
I need to be sure, but i think that replacing the bp_sticky_groups_loader() function by the following will fix PHP 5.4 strict error.
function bp_sticky_groups_loader() {
$bp = buddypress();
if( bp_is_active( 'groups' ) ) {
if( empty( $bp->groups->extend ) )
$bp->groups->extend = new stdClass();
$bp->groups->extend->bp_sticky_groups = BP_Sticky_Groups::instance();
}
}
Tomorrow, i’ll upgrade my php config and test the rest of the code in PHP 5.4, then i’ll publish an upgrade.
Thanks again 😉
Many thanks for another plugin.
Feedback from tests on local installs
single network.
Works-though on first refresh of group directory page an error notice appears even though the sticky group has actually come to the top
“There was an error saving, please try again.”
the error notice disappears on a subsequent refresh.
on a multi-network
the error notice appears but it appears to me that there is no “stickiness” – that is the group designated as sticky does NOT come to top.
the error notice disappears on a subsequent refresh BUT the group designated as sticky still does NOT come to top.
will try again tomorrow -Should have raised this as a new issue
Hi @valuser
you’re welcome 😉
I’m sorry i didn’t manage to reproduce. If you still have the trouble, would you mind open a new ticket ?
If you do so, don’t hesitate to give me details about BuddyPress version (1.8.1 or trunk ?), WordPress version (3.6.1), PHP, the way BuddyPress was activated in the network (from a blog admin or from the network admin)
From my point of view having such an error in groups directory page is very strange. Are you sure it’s not in the group (backend) admin ?
Thanks for your help
Thanks.
WP 3.6.1, BP 1.8.1,
for multi-network
BP Multi Network 0.1.1, Networks+ for WordPress 0.2.3.1 (premium-& well worth it)
I now think the error in single network MAY be caused by another good buddypress plugin.
http://wordpress.org/plugins/bp-group-documents/.
Please see image of error notice at http://i.imgur.com/dAvPn6T.png to confirm.
When in a single network (site) deactivating this plugin eliminates the error notice.
In any event, on a single site, the plugin works with bp-group-documents active but when bp sticky is changed the error notice appears and then disappears on page refresh.
still not working (for me) in multi-network even with bp-group-documents deactivated
About BP Group Documents, my reply here : http://wordpress.org/support/topic/conflict-with-bp-group-documents?replies=2#post-4646926
About Multi Networking : sorry 🙁 but not supported by this plugin. Plugin supports regular WordPress configs (single or multi).
Hi again @imath
I changed the function in the plugin with the function you listed above and I also removed the code I added to remove the error and I can confirm that it fixed the issue! Thank you again for the awesome plugin! Very handy indeed!
Thanks a lot @bphelp for your feedback
Just published 1.0.1 to include this change.
