Browser Rejector
[resolved] Some fixes (4 posts)

  1. yellyc
    Posted 2 years ago #

    I've just installed the plugin, great stuff!
    After a quick look at the code trying to figure out why my custom close window text wouldn't apply, I've found a few mistakes in the code (the first of which fixes the problem):

    1. In rejectr.js.php on line 63: "closelink:" => "closeLink:"
    2. In browser-rejector.php on line 139: "unpredictable&unstable" => "unpredictable&unstable" (using '&' directly is bad practice)
    3. In browser-rejector.php on line 461: "<![endif]-->" => "<!--[endif]-->"

    It would be great to see these fixes in the next version.
    Thank you for a great plugin!


  2. Nick Halsey
    Plugin Author

    Posted 2 years ago #

    Thanks for catching these! I've fixed them in the dev version, but am going to wait to push the update until I do a couple of fixes for IE6 support and bring in a translation that was submitted.

    And by the way, I double-checked the documentation but <![endif]--> is correct, the if (IE conditional comment) varies based on settings and is echoed by php, thus making a very long conditional comment that contains the entire rejection window html (because IE6 and 7 refuse to read the JS file that does the rejection). In other words, that line is already enclosed in <!--, just from way earlier. Both of the other catches were complete misses on my part though!

  3. yellyc
    Posted 2 years ago #

    cool, thanks for getting the fixes in so fast.
    Sorry for sending you back to the docs on the <![endif]-->, my bad.
    Also, just noticed that in 2, & amp; should have been written like I just did, but I guess you understood what I meant.

  4. Nick Halsey
    Plugin Author

    Posted 2 years ago #

    Yeah, the forums want backtics ` to stop things from rendering html, but I got it (actually just wrote out and since it doesn't really make any difference). And that's fine, it's always better to triple check!

Topic Closed

This topic has been closed to new replies.

About this Plugin

  • Browser Rejector
  • Frequently Asked Questions
  • Support Threads
  • Reviews

About this Topic


No tags yet.