Plugin breaks default "Add Media" functionality.

Thanks,

Looks like my patch didn’t upload properly :-/

I will get this fixed, but I’m afraid it will not be until this afternoon.

Sorry about this 🙁

Hi there,

The patch should be replacing the scripts.min.js with the following:

jQuery('.exhibition-image-upload').live( "click", function( e ) {

	var id = jQuery(this).attr('id')
	var id_split = id.split("-");
	exhibition_image_id = id_split[1];
	exhibition_src = jQuery(this).find('img').attr('src');

	jQuery(this).removeClass('exhibition-image-upload').addClass('exhibition-image-remove');
	jQuery(this).val('Remove Image');

	tb_show( '', ' media-upload.php?type=image&TB_iframe=true' );

	e.preventDefault();
	return false;
});

jQuery('.exhibition-image-remove').live( 'click', function( e ) {

	jQuery(this).remove();

	e.preventDefault();
	return false;
});

window.send_to_editor = function( html ) {

	var parent 			= jQuery( '#exhibition_image-' + exhibition_image_id ).parent();
	var image_url 		= jQuery( 'img', html ).attr('src');
	var image_id 		= jQuery( 'img', html ).attr('class');

	if( !image_url )
	{
		image_url = jQuery( html ).attr('src');
	}

	if( !image_id )
	{
		image_id = jQuery( html ).attr('class');
	}

	var image_output 	= '';
	image_id 			= image_id.replace(/[^0-9]/g,'');

	jQuery.post( ajaxurl, {
		action: 'exhibition_gallery',
		'image_id': image_id,
	},
	function(response) {
		image_output = response.substring(0, response.length - 1);

		jQuery( '#exhibition_image-' + exhibition_image_id ).val( image_url ).find('img').attr( 'src', image_url ).replaceWith( image_output );
		jQuery( '#exhibition_image-' + exhibition_image_id ).val( image_url ).find('input').val( image_id );
		jQuery( '#exhibition_image-' + exhibition_image_id ).append('<img class="exhibition-image-remove-hover" src="'+exhibition_src.replace( '/add.png', '/remove.png' )+'" alt="Remove image" />');

		parent.append('<button id="exhibition_image-' + ( parseInt( exhibition_image_id ) + 1 ) + '" class="exhibition-image-upload" value="Add Image" type="submit"><img src="'+exhibition_src+'" height="150" width="150" alt=""/><input type="hidden" name="exhibition_image-' + ( parseInt( exhibition_image_id ) + 1 ) + '" value=""/></button>');

		tb_remove();

	});
};

The key fix in this is the following block:

if( !image_url )
{
	image_url = jQuery( html ).attr('src');
}

if( !image_id )
{
	image_id = jQuery( html ).attr('class');
}

Basically the html variable that is passed into the window.send_to_editor function is an image tag, but sometimes WordPress puts it in a wrapper (which is what my original broken plugin checks for).

These two ifs, check to see if the variables have been set, and if they haven’t assumes that the html variable is not in a wrapper, and must be the img tag itself.

This was in the patch, but it looks like the minified version dosn’t contain the fix :-/

Give this a go, and if it dosnt work, will you dump out the contents of the html variable, as you may have a case that I am not taking into consideration.

Cheers 🙂

Actually, I’m going to try and fix it now, so if I do, I’ll post the fix here, and patch it later.

Hi again,

Right, I think I have a fix in place.

Try putting this in your min.scripts.js file:

jQuery('.exhibition-image-upload').live( "click", function( e ) {

	send_to_editor_temp = window.send_to_editor;

	var id = jQuery(this).attr('id')
	var id_split = id.split("-");

	exhibition_image_id = id_split[1];
	exhibition_src = jQuery(this).find('img').attr('src');

	jQuery(this).removeClass('exhibition-image-upload').addClass('exhibition-image-remove');
	jQuery(this).val('Remove Image');

	tb_show( '', ' media-upload.php?type=image&TB_iframe=true' );

	window.send_to_editor = function( html ) {

		var parent 			= jQuery( '#exhibition_image-' + exhibition_image_id ).parent();
		var image_url 		= jQuery( 'img', html ).attr('src');
		var image_id 		= jQuery( 'img', html ).attr('class');

		if( !image_url )
		{
			image_url = jQuery( html ).attr('src');
		}

		if( !image_id )
		{
			image_id = jQuery( html ).attr('class');
		}

		var image_output 	= '';
		image_id 			= image_id.replace(/[^0-9]/g,'');

		jQuery.post( ajaxurl, {
			action: 'exhibition_gallery',
			'image_id': image_id,
		},
		function(response) {
			image_output = response.substring(0, response.length - 1);

			jQuery( '#exhibition_image-' + exhibition_image_id ).val( image_url ).find('img').attr( 'src', image_url ).replaceWith( image_output );
			jQuery( '#exhibition_image-' + exhibition_image_id ).val( image_url ).find('input').val( image_id );
			jQuery( '#exhibition_image-' + exhibition_image_id ).append('<img class="exhibition-image-remove-hover" src="'+exhibition_src.replace( '/add.png', '/remove.png' )+'" alt="Remove image" />');

			parent.append('<button id="exhibition_image-' + ( parseInt( exhibition_image_id ) + 1 ) + '" class="exhibition-image-upload" value="Add Image" type="submit"><img src="'+exhibition_src+'" height="150" width="150" alt=""/><input type="hidden" name="exhibition_image-' + ( parseInt( exhibition_image_id ) + 1 ) + '" value=""/></button>');

			tb_remove();
		});
		window.send_to_editor = send_to_editor_temp;
	};

	e.preventDefault();
	return false;
});

jQuery('.exhibition-image-remove').live( 'click', function( e ) {

	jQuery(this).remove();

	e.preventDefault();
	return false;
});

Now when you click the button window.send_to_editor() is stored in a temporary variable, and then reassigned when the whole thing is over.

It seems to work for me, but if you have any more trouble let me know and I’ll jump on it.

I will put this in an official fix tonight after I’ve done some more testing.

Fantastic 🙂

I will push the patch later tonight and close the thread 🙂

Thanks for all your help in getting this working.