Plugin breaking Advanced Ads

  • Resolved delikatesy

    (@delikatesy)


    6 years, 1 month ago

    Hello,
    thanks for the plugin, it helped with multiple queries on my homepage. I’ve noticed, that when activated, Advanced Ads doesn’t let you select any ads in your ad placements.
    Can your function be adjusted, so other plugins which are trying to inject into content won’t collide?

    thanks
    Viktor

Viewing 6 replies - 1 through 6 (of 6 total)
  • Thomas Maier

    (@webzunft)

    6 years, 1 month ago

    I am the author of Advanced Ads and just wanted to leave a note here saying that you can ping me if any of you need my help.

    Thomas

    Thread Starter delikatesy

    (@delikatesy)

    6 years, 1 month ago

    Hello Thomas,

    thanks for picking this up.
    What’s happening is, that when Avoid Duplicate Posts is turned on on a customized TwentySeventeen theme, in Advanced Ads you cannot select ads when viewing their Locations. The dropdowns just show groups (if they exist), but no ads. If I turn off Avoid DP, then it’s back to normal.

    thanks
    Viktor

    Thomas Maier

    (@webzunft)

    6 years, 1 month ago

    Hi Viktor,

    thanks for your reply.

    Could you please try Advanced Ads 1.10.4 which I just released? I fixed a conflict caused by a theme there that sounds similar to yours. If that doesn’t help then I fear that Avoid Duplicate Posts needs to jump in. I have seen similar issues when the query was manipulated by a plugin and that was not limited to specific pages. I am just guessing here, but it might help to limit their changes to post lists only and not apply it to all post types.

    S pozdravom,
    Thomas

    Thread Starter delikatesy

    (@delikatesy)

    6 years, 1 month ago

    Hi Thomas,

    I’ve updated your plugin (note that I’m on Pro with your plugin), activated ADP and the problem is persistent. On the other had, this is clearly a problem with ADP, as out of the box, it was breaking my site. When I’ve removed the limit to work only on some sections, then it works.
    Something similar was described in this support topic https://wordpress.org/support/topic/doesnt-work-at-all-102/

    Anyway, I’ll play around with it and might get it to work. If you say, that one has to limit the query manipulation to certain pages, then maybe that’s the way to go (I only need ADP on home and category archives).

    All in all this is an issue od ADP, not AdvAds, but really appreciate your effort. Keep up the good work.

    thanks
    Viktor

    Thread Starter delikatesy

    (@delikatesy)

    6 years, 1 month ago

    Hello all,

    not sure what it was, but when I’ve moved the plugin code directly to the theme functions.php and changed is_home to is_front_page, it started to work.

    thanks
    Viktor

    Plugin Author MyThemeShop

    (@mythemeshop)

    6 years ago

    Hello @delikatesy

    Sorry for any inconvenience that might have been caused due to that.

    I am glad that you have managed to fix the issue. I am closing the ticket. If you need further assistance let us know.

    Thank you.

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Plugin breaking Advanced Ads’ is closed to new replies.

Tags