[Plugin: Advanced Post List] Maximum execution time after update

Thank you for the feedback. I believe it has something to do with CPT, and it may be awhile til I can provide a proper fix. So, for the time being, I would recommend using version 0.2.0. The only downside is that it doesn’t support CPT.

Sorry I can’t provide an ideal solution right now, but it is an issue that I’ll need time to investigate.

Ok, I was able to debug inside the function to better understand what was going on. If I was to ask you if your site has quite a bit of posts/pages, and your response is yes. Then I’m fairly certain now that I have a fix for this.

Original
(Version 0.3.b5)
/wp-content/plugins/advanced-post-list/includes/APL-admin.php
Function at Line 218

function APL_get_page_heirarchy($page_settings = array('post_type_name' => 'post'),
                                $parent = 0,
                                $depth = -1)
{
    $rtnString = '';
    $dashes = '';
    if ($depth == -1)
    {
        $rtnString .= '<option id="slctChkCurrent-' . $page_settings['post_type_name'] . '" value="' . 0 . '"><b>Current Page</b></option>';
    }
    $depth++;
    for ($i = 0;
            $i < $depth;
            $i++)
    {
        $dashes .= '-';
    }

    $argPages = array('numberposts' => -1,
        'orderby' => 'title',
        'order' => 'ASC',
        'post_type' => $page_settings['post_type_name']);
    $pages = get_posts($argPages);

    foreach ($pages as $page)
    {

        if ($page->post_parent == $parent)
        {

            $id = $page->ID;
            $rtnString .= '<option value="' . $page->ID . '">' . $dashes . $page->post_title . '</option>';
            $rtnString .= APL_get_page_heirarchy($page_settings,
                                                 $id,
                                                 $depth);
        }
    }

    return $rtnString;
}

Modified

function APL_get_page_heirarchy($page_settings = array('post_type_name' => 'post'),
                                $parent = 0,
                                $depth = -1)
{
    $rtnString = '';
    $dashes = '';
    if ($depth == -1)
    {
        $rtnString .= '<option id="slctChkCurrent-' . $page_settings['post_type_name'] . '" value="' . 0 . '"><b>Current Page</b></option>';
    }
    $depth++;
    for ($i = 0;
            $i < $depth;
            $i++)
    {
        $dashes .= '-';
    }

    $argPages = array(
        'numberposts' => -1,
        'orderby' => 'title',
        'order' => 'ASC',
        'post_type' => $page_settings['post_type_name'],
        'post_parent' => $parent
        );
    $pages = get_posts($argPages);

    foreach ($pages as $page)
    {

        if ($page->post_parent === $parent)
        {

            $id = $page->ID;
            $rtnString .= '<option value="' . $page->ID . '">' . $dashes . $page->post_title . '</option>';
            $rtnString .= APL_get_page_heirarchy($page_settings,
                                                 $id,
                                                 $depth);
        }
    }

    return $rtnString;
}

This should speed things up 60-80 times faster than what it was. Depending on how deep your site’s page hierarchy is. For now, to keep it simple, all I did was add the post_parent filter (which I thought I did add, must have missed it) to prevent having to process unnecessary data, but I do plan on optimizing it further for the next update. Before I add 0.3.b6 though, I need to get some other issues fixed, but for now, this should fix it. Please let me know how it turns out though.