Support » Plugin: WordPress Hide Posts » Plugin adds has-sub class to menu items

  • Resolved gamerwithadegree

    (@gamerwithadegree)


    Hi,

    Just found this plugin, it seems exactly what I need. I have an issue though, on activation, the hide posts plugin seems to add the class has-sub to all menu items, even ones that don;t have any sub items.

    I use basic HTML and CSS menu but it has a custom walker.

    Walker Code;

    //menu walker to extend WP Menu
    
    class CSS_Menu_Walker extends Walker {
    
      var $db_fields = array( 'parent' => 'menu_item_parent', 'id' => 'db_id' );
    
      function start_lvl( &$output, $depth = 0, $args = array() ) {
        $indent = str_repeat("\t", $depth);
        $output .= "\n$indent<ul>\n";
      }
    
      function end_lvl( &$output, $depth = 0, $args = array() ) {
        $indent = str_repeat("\t", $depth);
        $output .= "$indent</ul>\n";
      }
    
      function start_el( &$output, $item, $depth = 0, $args = array(), $id = 0 ) {
    
        global $wp_query;
        $indent = ( $depth ) ? str_repeat( "\t", $depth ) : '';
        $class_names = $value = '';
        $classes = empty( $item->classes ) ? array() : (array) $item->classes;
    
        /* Add active class */
        if(in_array('current-menu-item', $classes)) {
          $classes[] = 'active';
          unset($classes['current-menu-item']);
        }
    
        /* Check for children */
        $children = get_posts(array('post_type' => 'nav_menu_item', 'nopaging' => true, 'numberposts' => 1, 'meta_key' => '_menu_item_menu_item_parent', 'meta_value' => $item->ID));
        if (!empty($children)) {
          $classes[] = 'has-sub';
        }
    
        $class_names = join( ' ', apply_filters( 'nav_menu_css_class', array_filter( $classes ), $item, $args ) );
        $class_names = $class_names ? ' class="' . esc_attr( $class_names ) . '"' : '';
    
        $id = apply_filters( 'nav_menu_item_id', 'menu-item-'. $item->ID, $item, $args );
        $id = $id ? ' id="' . esc_attr( $id ) . '"' : '';
    
        $output .= $indent . '<li' . $id . $value . $class_names .'>';
    
        $attributes  = ! empty( $item->attr_title ) ? ' title="'  . esc_attr( $item->attr_title ) .'"' : '';
        $attributes .= ! empty( $item->target )     ? ' target="' . esc_attr( $item->target     ) .'"' : '';
        $attributes .= ! empty( $item->xfn )        ? ' rel="'    . esc_attr( $item->xfn        ) .'"' : '';
        $attributes .= ! empty( $item->url )        ? ' href="'   . esc_attr( $item->url        ) .'"' : '';
    
        $item_output = $args->before;
        $item_output .= '<a'. $attributes .'><span>';
        $item_output .= $args->link_before . apply_filters( 'the_title', $item->title, $item->ID ) . $args->link_after;
        $item_output .= '</span></a>';
        $item_output .= $args->after;
    
        $output .= apply_filters( 'walker_nav_menu_start_el', $item_output, $item, $depth, $args );
      }
    
      function end_el( &$output, $item, $depth = 0, $args = array() ) {
        $output .= "</li>\n";
      }
    }

    This walker is only from my main nav menu, footer and mobile menus are unaffected.

    I think this part of the Walker could be causing some conflict with your plugin.

    /* Check for children */
        $children = get_posts(array('post_type' => 'nav_menu_item', 'nopaging' => true, 'numberposts' => 1, 'meta_key' => '_menu_item_menu_item_parent', 'meta_value' => $item->ID));
        if (!empty($children)) {
          $classes[] = 'has-sub';
        }

    I am unsure how to fix this issue, can you possibly offer some advice?

    Thanks.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Martin

    (@martin7ba)

    Hello,

    There have been a lot of issues with the menus.

    I added fix in the latest version 0.5.1 which I hope it will fix all menu related issues. Can you please update to the latest version and let me know if it works.

    Best,
    Martin

    gamerwithadegree

    (@gamerwithadegree)

    Hi,

    Yes, it works now. No conflict with the menu anymore, great job.

    Thanks.

    Plugin Author Martin

    (@martin7ba)

    Great, good to hear.

    Best,
    Martin

Viewing 3 replies - 1 through 3 (of 3 total)
  • You must be logged in to reply to this topic.