Support » Plugin: Simple Colorbox » Please update to latest Colorbox

  • Resolved SiamKreative

    (@siamkreative)


    Hi Ryan,

    Thanks for this great plugin. I switch from jQuery Colorbox to this one as I love simplicity.

    However, after activating the plugin, the modals were not properly styled (happened with all themes I tried). This didn’t when I used the latest colorbox from Github. Therefore, I quickly found out that Simple Colorbox an outdated version of Colorbox:

    • Current Colorbox version: v1.5.10
    • Current Colorbox version in your plugin: v1.3.19

    I’d be grateful if you could update your plugin’s dependencies. I’m 99% sure updating Colorbox won’t break anything as they’re all minor tweaks and fixes, nothing serious (no code refactoring).

    I’m happy to help if you decide to also host your plugin on Github. There is a couple of other things that could be improved.

    Cheers

    https://wordpress.org/plugins/simple-colorbox/

Viewing 9 replies - 1 through 9 (of 9 total)
  • Plugin Author Ryan Hellyer

    (@ryanhellyer)

    I didn’t even realise it was out of date 🙂 Thanks for letting me know.

    I’ve jotted a note down to myself to update Colorbox ASAP. I’ll try to get it done this evening, but if not probably tomorrow. If you notice I haven’t done it after that, then feel free to pester me about it 🙂

    Awesome! Thanks.

    I also thought it would be nice to:

    1. Have a new constant to specify whether to load the inline_script in the wp_head or wp_footer (in my opinion it should defaults to footer).
    2. Eventually “improve” the way you inlined the main script (See below)

    I was thinking of something like this, which I believe is a bit cleaner:

    function inline_scripts() {
    	if ( wp_script_is( 'jquery', 'done' ) ) {
    		?>
    		<script type="text/javascript">
    		jQuery(document).ready(function ($) {
    			if (jQuery().colorbox) {
    
    				// MAIN SCRIPT GOES HERE:
    				// 1) It will only be loaded if jQuery is loaded
    				// 2) It will only be executed if Colorbox is loaded
    
    			}
    		});
    		</script>
    		<?php
    	}
    }
    add_action( 'wp_footer', 'inline_scripts' );

    Lemme know what you think.

    Plugin Author Ryan Hellyer

    (@ryanhellyer)

    Perhaps it should always go in the footer instead of requiring a constant?

    Agreed. Looking forward to see the update notification 😉

    Hye Ryan,

    Just wanted to remind you about this 🙂

    Plugin Author Ryan Hellyer

    (@ryanhellyer)

    Thanks for the reminder. I started doing the upgrade, then part way through realised that a lot of the changes I had made previously were not present in this version. Then I realised that I had never pushed the latest version into the repository :/ I made it in 2013, but it has just been sitting as a beta on my site since then :/
    http://geek.ryanhellyer.net/2013/08/18/simple-colorbox-version-1-5/

    It already has a better way of handling the inline script implemented and a newer version of Colorbox. It’s not the latest version of Colorbox though, so I’ll update that and push out a new version (into the repository this time) for you. I’ll post back here once it’s ready.

    Plugin Author Ryan Hellyer

    (@ryanhellyer)

    Version 1.6 is now available for download 🙂
    http://wordpress.org/plugins/simple-colorbox/

    Plugin Author Ryan Hellyer

    (@ryanhellyer)

    Here’s the announcement post and a demo of it in action … http://geek.ryanhellyer.net/2014/07/19/simple-colorbox-version-1-6-released/

    Thanks Ryan! Much appreciated.

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘Please update to latest Colorbox’ is closed to new replies.