• The most recent updates have changed from using HTML tables to represent tabular data to DIVs.

    There are a few issues with this implementation:

    1/ This breaks backwards compatibility with those of us who have disabled RCPs built-in styles and have styled the tables appropriately

    2/ The use of DIVs to build tables is not semantic. Tabular data should be represented using table elements.

    3/ The markup is now invalid. For example, only one MAIN element should appear on the page, but it has been used as a TBODY.

    I really don’t understand the thought process behind this change.

    If it’s to make the content display better on mobile, you can continue to use tables and apply whatever CSS you like to the TABLE, THEAD, TBODY, TD, TH, TD and TFOOT elements.

    It’s also possible to implement scrollable tables by setting the TABLE to display block and overflow scroll.

    Please consider reverting back to HTML tables to maintain semantic, valid HTML and backwards compatibility.

    Jamie

Viewing 15 replies - 1 through 15 (of 16 total)
  • Plugin Author James Welbes

    (@highprrrr)

    Hi @jamieburchell !

    Thank you so much for your feedback! We’ll certainly take this into consideration.

    The extra <main> tag was definitely a mistake. I have fixed this and it should be in the next release.

    Thread Starter jamieburchell

    (@jamieburchell)

    Will you be reverting back to using actual tables @highprrrr i.e:

    <table>
      <thead>
        <tr>
          <th></th>
        </tr>
       </head>
       <tbody>
         <tr>
           <td></td>
         </tr>
       </tbody>
    </table>

    instead of

    <div>
      <header>
        <div>
          <span></span>
        </div>
      </header>
      <div>
        <span></span>
      </div>
    </div>

    If not, I need to spend time re-styling RCP pages, especially as the new markup doesn’t seem consistent for every “table”.

    Plugin Author James Welbes

    (@highprrrr)

    @jamieburchell

    I wanted to thank you for your feedback.

    After some deliberation and research, I believe we will go back to Tables.

    We’re going to warn people first before we change again, so as to give folks like yourself time to plan for it. And we’ll probably offer a “beta” zip for folks who want to get a jump start on it.

    Right now I’ve got a working example that uses table/row/td etc and is actually quite responsive (much MUCH better than it was before, which I understand isn’t saying much).

    If you’d like, I could share a link to a zip here and you could have a sneak peak.

    Thread Starter jamieburchell

    (@jamieburchell)

    Hi @highprrrr

    That’s great news and I’m pleased that you are prepared to revert the change for the benefit of the project. Thanks for sharing the information here.

    I’d gladly take a look at the beta version if you need some feedback or a second pair of eyes, otherwise I am equally happy to wait until this is released.

    Thanks again
    Jamie

    Plugin Author James Welbes

    (@highprrrr)

    @jamieburchell

    This page is still a work in progress, but the zip is downloadable:

    https://restrictcontentpro.com/beta/

    Thread Starter jamieburchell

    (@jamieburchell)

    Do you have a timeline for when the table styling will be reverted? I’m holding off updating because of this but don’t want to miss other updates. I submitted a couple of feedback entries for the beta file, not sure if you go them but basically I found some areas still had the new div styling.

    Thread Starter jamieburchell

    (@jamieburchell)

    Bump @highprrrr

    Latest beta I tried from October did not revert to tables for all areas.

    Plugin Author James Welbes

    (@highprrrr)

    Not all areas were tables even before we updated. Which areas in particular are you looking at?

    Thread Starter jamieburchell

    (@jamieburchell)

    @highprrrr

    Disappointing that the feedback I submitted on the beta didn’t get reviewed and there doesn’t appear to be a process in place for the developers to see what they have changed.

    register-total-details.php used to be a table, it’s now made with divs.

    subscription.php – account overview and payment history tables – <thead> is now missing a <tr> row for the child <td>s (which were also changed from <th>, please can this be reverted too)

    Thanks
    Jamie

    Thread Starter jamieburchell

    (@jamieburchell)

    Any news on getting this corrected @highprrrr ?

    subscription.php – account overview and payment history tables – <thead> is now missing a <tr> row for the child <td>s (which were also changed from <th>, please can this be reverted too)

    Plugin Author James Welbes

    (@highprrrr)

    Hi @jamieburchell we’re hoping to release this soon.

    You can check out the latest beta version updated a couple weeks ago: https://restrictcontentpro.com/beta/

    Thread Starter jamieburchell

    (@jamieburchell)

    @highprrrr The latest beta version released a couple of weeks ago still has the issue.

    subscription.php – account overview and payment history tables – <thead> is now missing a <tr> row for the child <td>s (which were also changed from <th>, please can this be reverted too)

    I did already report this here and twice via the feedback form.

    Plugin Author James Welbes

    (@highprrrr)

    Oh, shoot you know what I completely misread that some how before.

    I see what you mean now.

    Refresh the beta page, there should be a new entry for Feb 7th. Try that zip and let me know.

    I tested it on 2021, 2020, Kadence, Astra, and Hello Elementor and saw no issues.

    Thread Starter jamieburchell

    (@jamieburchell)

    @highprrrr Nearly there – please can you revert the <td> back to <th> in both of those tables, as these are header cells within the <thead> and not regular data cells. This is what they used to be before the changes were made too.

    Plugin Author James Welbes

    (@highprrrr)

    d’oh, you’re absolutely correct 0_0

    I’ve updated those tds and made them ths.

    This will go out in our next release, which we were hoping might be this week but our lead dev is out sick today so it might have to wait until next week.

    Also you’re right about that zip I’ll take that down.

Viewing 15 replies - 1 through 15 (of 16 total)
  • The topic ‘Please don’t use divs to create tables of data’ is closed to new replies.