player stats and player list still wrong

@theangryduck Upon further testing I’ve found that although automatic statistics (calculated from event performance) were adding up properly, manually statistics (entered directly into the player profile) were not counted in the totals. If you’ve entered statistics directly into the player, this would be the case.

I’ve just committed a fix to GitHub, where the total statistics are being calculated by adding all values from that table. This will be included in the next update.

• This reply was modified 7 years, 8 months ago by Brian.

@jdembowski Noted.

@theangryduck Since I’m unable to reproduce this exact issue on my test site, let’s follow the touchpoints of those statistics to see if we can get to the bottom of it:

1. Event Performance (Box Scores) – These are calculated first, by looking at all of the played events for each player and adding up their performance from each of those events.

2. Player Profile (Statistics) – When editing a player directly, these are the values entered directly into the Statistics section where you can select the team they played on for each season. If the competition and season match up exactly with that of the player list, these values will override those calculated from 1 (above).

3. Player List (Adjustments) – When editing a player list, you’ll notice an “Adjustments” tab at the top of the table. By switching to the Adjustments table, you can enter values greater or less than zero, to add or subtract this amount from that player’s statistic.

4. Player List (Values) – And finally, the Values table itself. Any values entered directly into this table will override all other values calculated from 1, 2, and 3.

With each field where you can enter a value, there are grey text (placeholder) values, which are those from an earlier touchpoint, and black text (manual) values, which override them instead.

In this case, I suspect there might be manually entered values in that player’s profile, or in the Adjustments table. It’s impossible for me to tell for sure, but you’ll be able to check from the dashboard.

Try following the touchpoints for Leon as an example, and let me know what you find. Thanks!

@theangryduck

Thanks for clarifying those points, this actually makes a lot more sense now.

As you know, SportsPress has evolved over time, with new features being added in every update. One of the big changes we made early on was to introduce multi-competition and multi-season player lists linked to player stats.

The problem is, player lists were not originally designed to be used with a combination of manual and automatic player stats across multiple seasons. It works as intended only if you select one competition and one season, by either showing the (automatic) calculated values or (manual) player stats.

When a player list attempts to combined automatic and manual stats, issues start to arise. It only makes one database call to retrieve a list of events, then iterates through those events to calculate each player’s performance. Now, if it wants to compare those stats with the manual stats entered directly into each player profile, it would need to make multiple database calls to either:

1. Get events for each competition/season combination (this is what it does when viewing player profiles directly, which also explains why those statistics are more in-depth and accurate)

or

2. Look at which competition and season each event belongs to, then match those up against the manually entered player stats and decide whether these stats have been accounted for.

Unfortunately, player lists are already very resource-intensive, and adding more database calls will only make them even slower.

So here’s what we’ve decided to do:

With the next update, player profile stats and player list values will no longer be connected to each other. This means that you can modify player profile stats directly if you wish, but these will not affect the behavior of player lists.

The two will still share a common touchpoint: event performance. All automatic values calculated from events will be reflected in player profiles and player lists, just as they have been.

Now, for the workaround: If you’ve got stats from previous seasons and wish to add them to the player list (without adding the events themselves), you can use the “Adjustments” table within the player list. By adding the totals of past seasons here, the main “Values” table will reflect a new total using those adjustments and automatically calculated values.

I hope this all makes sense. Moving on from legacy behavior and disconnecting player stats from player lists is a tough decision but we think it is a decision we need to make.