WordPress.org

Forums

Memcached Object Cache
PHP Notice: Undefined offset with default bucket (3 posts)

  1. Dennis
    Member
    Posted 2 years ago #

    I dropped in memcached for some tests in a multisite installation (WordPress 3.4.1). I get a PHP Notice (Undefined offset: 1 in /wp-content/object-cache.php on line 374").

    In line 365 the plugin defines the default bucket:
    $buckets = array('127.0.0.1');

    and tries this in line 374:
    list ( $node, $port ) = explode(':', $server);

    where $server is '127.0.0.1'.

    I changed the assignement for the default bucket to:
    $buckets = array('127.0.0.1:' . ini_get('memcache.default_port'));
    to fix the undefined offset.

    I would love to get some feedback. Is this safe to do? If yes, maybe we could consider to add this in the next release of memcached?

    http://wordpress.org/extend/plugins/memcached/

  2. Mike Bijon
    Member
    Posted 2 years ago #

    Hi Dennis,
    PHP Notices are good to avoid, but won't harm the system or functionality of this plugin. They can be annoying if you log Notices in order to update a site or remove deprecated code ... but until WordPress and the plugin repo have better test coverage, preventing Notices all the time may remain a personal preference.

    What you're doing isn't harmful, although it does create another potential Notice case:
    In the event that this plugin is enabled but the admin hasn't set 'memcache.default_port' then a new Notice will occur when your ini_get() is run. This is unlikely, but if you're going to open a door you may as well go all the way. To prevent that case you'll want to add something before that $buckets = line, which will test if 'memcache.default_port' is set and create a default port if not.

    ----

    On the general idea of preventing Notices:

    There is code in WP core devs that does this: 'if ( $var ) ...' which doesn't prevent Notices like 'if ( ! isset( $var ) ) ...' My personal preference is isset(), but that's because I think it's more readable.

    The WP code conventions don't note a preference in preventing Notices. Because I'm overthinking this already, I think it's worth putting effort into isset() so your code if more clear: http://make.wordpress.org/core/handbook/coding-standards/#clever-code

    There's some dispute about the performance of testing for existence. That could be with older versions of PHP, or due to redundant, duplicate tests. With modern PHP I think there's not a significant performance impact: http://www.brandonchecketts.com/archives/php-performance-isset-versus-empty-versus-php-notices. And on big server clusters that aggregate logs, I think preventing Notices would end up being more performant.

  3. Matt Martz
    Member
    Plugin Author

    Posted 2 years ago #

    @Dennis,

    Thanks for the report. I had added code to fix that, and I am wondering what happened to it in the repo. Perhaps I never actually committed it. I'll go back and check.

Topic Closed

This topic has been closed to new replies.

About this Plugin

  • Memcached Object Cache
  • Frequently Asked Questions
  • Support Threads
  • Reviews

About this Topic