Viewing 12 replies - 1 through 12 (of 12 total)
  • Thread Starter raptor235

    (@raptor235)

    This also created another issue…

    If I disable show_in_rest for the post type ( essentially disablign Gutenberg for that post type )

    Revisory no longer works with this post type… isBlockEditorActive still returns true even though show_in_rest is turned off for the post and I have classic editor turned off.

    You guys should probably check for that.

    Thread Starter raptor235

    (@raptor235)

    Because essentially submit for review button is missing but send to approval queue checkbox is still there but it does nothing

    http://www.flowpress.com/screenshots/screenshot%202019-04-10%20at%208.44.54%20AM.png

    Maybe a warning or notice saying classic editor should be active.

    Thread Starter raptor235

    (@raptor235)

    Enabling classic editor still doesn’t return the “Submit Revision” button

    http://www.flowpress.com/screenshots/screenshot%202019-04-10%20at%208.45.55%20AM.png

    So the only way for me to enable “Submit for review” is to disable classic editor, turn on show_in_rest for the post_type which then works but that’s where I’m seeing your noitces as stated above

    http://www.flowpress.com/screenshots/screenshot%202019-04-10%20at%208.47.04%20AM.png

    Plugin Author Kevin Behrens

    (@kevinb)

    @raptor235, does this answer your question?

    https://wordpress.org/support/topic/multi-role-support-multi-post-type/#post-11413026

    The “Submit for review” checkbox is not necessary when your role is properly configured. It is only displayed as a way for unrestricted editors to voluntarily submit to revision moderation.

    • This reply was modified 5 years, 2 months ago by Kevin Behrens.
    Thread Starter raptor235

    (@raptor235)

    No we still have the massive notices in the screenshot above… I don’t think the two are releated.

    Plugin Author Kevin Behrens

    (@kevinb)

    Yeah, I’ll resolve the notice.

    But you’ve raised this separate issue about the presence of a “send to approval queue” checkbox, which points to a configuration issue with your role.

    Thread Starter raptor235

    (@raptor235)

    @kevinb

    But it seems to only show when gutenberg for that post type is disabled, I feel like detection on your end if show_in_rest is off isn’t done… cause things look proper when gutenberg is enabled ( except notices ) but when show_in_rest is off and gutenberg doesn’t show your JS doesn’t run to replace the button with submit for review.

    Plugin Author Kevin Behrens

    (@kevinb)

    The checkbox is not displayed in Gutenberg because we have not yet developed the Gutenberg-compatible UI for it. This is an optional (and non-essential) feature for Editors / Administrators, not part of the normal revision submission process.

    That said, I agree that I need to look at show_in_rest to correctly load the Classic Editor scripts for the show_in_rest = false condition. I’ll post updated dev code for that shortly.

    Thread Starter raptor235

    (@raptor235)

    Thanks @kevinb really apprechite it.

    Plugin Author Kevin Behrens

    (@kevinb)

    @raptor235: FYI, the PHP notice is my issue, but also indicates that you are executing a REST Posts query with a URL that does not correspond to any post type’s rest_base property.

    In other words, the REST URL is normally in the form /wp-json/wp/v2/{rest_base} or /wp-json/wp/v2/{$rest_base}/{$post_id}

    …where {$rest_base} is the value of some post type’s rest_base property.

    The PHP notice is occurring for a REST Posts query that does not match that pattern.

    Plugin Author Kevin Behrens

    (@kevinb)

    I’ve updated the Revisionary development version to 1.3.6-beta4 with these fixes:

    • Fixed : Gutenberg: Pending, Scheduled Revisions did not work for post types with show_in_rest property set false
    • Fixed : PHP Notice if REST Posts query executed without a corresponding rest_base property set for post type
    Thread Starter raptor235

    (@raptor235)

    Thanks @kevinb I’ll check it out today

Viewing 12 replies - 1 through 12 (of 12 total)
  • The topic ‘PHP Notice’ is closed to new replies.