PHP Fatal error

Hi Asad,
I haven’t done much really. The 4.1.1 update came with a notice to upgrade analytics.js:

Analytify introduced the new gtag.js tracking mode. Switch it now from plugin Advanced settings to use recommended Google Analytics gtag.js tracking method

To make that notice go away, I did as it suggests. I don’t use the plugin’s dashboard much, as I prefer the widget. Hitting Analytify > Dashboards now lands on a “There has been a critical error on this website” notice, and debug.log has the aforementioned entry. Suspecting a bug with this release, I even tried rolling back to a few previous versions of wp-analytify, but the error still occurs for me. Skimming through the latest code now, it becomes apparent it handles $accounts being null/empty/false, or an array, but there’s no check for $accounts not being an object. I don’t know why mine isn’t, but an is_object($accounts) check right before using the foreach clause seems consistent with the rest of the code.

I looked some more into the issue.

The reason for the error happens from fetch_profiles_list_summary() fetching the profiles_list_summary option from the DB, which contains a long json string that appears to be malformed in my configuration. I deleted that option and it got re-fetched, apparently properly formatted this time, as it fixed the issue. I compared both strings and they’re indeed different.

As said in the previous post, I noticed this error in the current version, but it goes way back, as I don’t open the dashboard much but prefer the widget instead.

Looking at both json strings now, noticed references to domain.com in the malformed one and www.domain.com in the re-fetched one. Some time ago, I indeed changed the websiteUrl from domain.com to www.domain.com side-wide for SEO purposes, so perhaps something got messed up (although haven’t noticed any other issues so far).

I understand this would be an edge case to the team, hence the unwillingness to address it. As probably is well known it’s a good practice to do at least a basic check of any data fetched from a remote origin. So still considering an extra check to $accounts containing properly formed json data would make the code a bit more resilient, and error handling some more graceful.

HTH.