PHP compatibility warnings from your plugin

  • Resolved moisb

    (@moisb)


    5 years, 2 months ago

    Hello, today I did a compatibility test to update my website from PHP 7.0.x to PHP 7.1.x.
    There were some warnings from your plugin. Obviously I know this does not stop the plugin, however it is interesting to check the warnings to avoid future problems 🙂

    FILE: htdocs/wp-content/plugins/wp-asset-clean-up/freemius/includes/fs-essential-functions.php
    —————————————————————————————————————————————-
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    —————————————————————————————————————————————-
    175 | WARNING | Function name “__fs” is discouraged; PHP has reserved all method names with a double underscore prefix for future use.
    —————————————————————————————————————————————-

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Gabe Livan

    (@gabelivan)

    5 years, 2 months ago

    @moisb, this warning is from a global function “__fs” within the Freemius WordPress SDK and it will not be triggered in the front-end view. It will only be declared (never triggered) as a function within the Dashboard. The function has been replaced with fs_text(). Moreover, the PHP file uses function_exists() to check if it was already declared (to avoid further conflicts in case a different plugin uses the same SDK).

    This shouldn’t stop the plugin from working in any way and in my tests, in PHP 7+ (I’m using WP_DEBUG always set to true) no warning was ever shown.

    Thanks for posting this and in case I will later use my own code (this SDK is quite heavy for what I need), this kind of warnings won’t be shown again via the tools you’ve used to check for the compatibility (I suppose you used WP Engine’s “PHP Compatibility Checker” plugin).

    Thread Starter moisb

    (@moisb)

    5 years, 2 months ago

    @gabelivan I got it! Thank you very much for your attention.

    Yes, I used the WP Engine plugin.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘PHP compatibility warnings from your plugin’ is closed to new replies.