PHP code proposal

Hi
In this same validator. You can test this url https://intersindicalrm.org/.
In Firefox is error 2, in Chrome error 1.
I use a software called pagespeed module for doing web optimizations and uses and html parser and throw the same error:
[Mon, 21 Mar 2022 17:22:01 GMT] [Info] [1214] [https://intersindicalrm.org/:1] Unexpected close-tag svg, no tags are open
When a space is set between > and </svg> the error is not reported

• This reply was modified 3 years, 3 months ago by lofesa.
• This reply was modified 3 years, 3 months ago by lofesa.
• This reply was modified 3 years, 3 months ago by lofesa.
• This reply was modified 3 years, 3 months ago by lofesa.

Hi
1.- About <style> tag, you can´t view it because I changed the php files to make it conditional
2.- About the closing /, it comed from Smart Slider, see:
In the SliderTypeSimpleFrontend.php this is used: $this->displaySizeSVGs($css);
In the AbstractSliderTypeFrontend.php is the displaySizeSVGs function and have:
`$svgs = array(
Html::tag(‘svg’, $attrs, ”)
);`
In the Nextend/Framework/View/Html.php is the function Html::tag:
public static function tag($tag, $htmlOptions = array(), $content = “”, $closeTag = true) {
$html = ‘<‘ . $tag . self::renderAttributes($htmlOptions);
if ($content === false) return $closeTag && self::$closeSingleTags ? $html . ‘ />’ : $html . ‘>’; else
return $closeTag ? $html . ‘>’ . $content . ‘</’ . $tag . ‘>’ : $html . ‘>’ . $content;
}
As far as Html::tag('svg', $attrs, '') has a null $content and $closeTag and self::$closeSingleTags are true, the /> is added.
If I put some string as $content the /> is ommited.

3.- If I do var_dump() off $attrs there is the xmlns="http://www.w3.org/2000/svg" is here but the var-dump() of $svgs does not have it.

To make these test I have disabled autoptimize and pagespeed.

Hi @nextendweb_gabor

Yes, I have modified this part:

$svgs = array(
    Html::tag('svg', $attrs, '#')
);

where # mus be read as blank space.
Then here:

public static function tag($tag, $htmlOptions = array(), $content = “”, $closeTag = true) {
$html = ‘<‘ . $tag . self::renderAttributes($htmlOptions);
if ($content === false) return $closeTag && self::$closeSingleTags ? $html . ‘ />’ : $html . ‘>’; else
return $closeTag ? $html . ‘>’ . $content . ‘</’ . $tag . ‘>’ : $html . ‘>’ . $content;
}

$content is not empty so / is not added and the </svg> is not orphan

Hi @nextendweb_gabor

The space is not the issue. The issue is the ending /.

As stated by @nextend_ramona

the opening svg tag has the / makes the validator throw and error.

Your code, in this case:

public static function tag($tag, $htmlOptions = array(), $content = “”, $closeTag = true) {
$html = ‘<‘ . $tag . self::renderAttributes($htmlOptions);
if ($content === false) return $closeTag && self::$closeSingleTags ? $html . ‘ />’ : $html . ‘>’; else
return $closeTag ? $html . ‘>’ . $content . ‘</’ . $tag . ‘>’ : $html . ‘>’ . $content;
}

makes the <svg......./></svg> as far as $content is empty and $closeTag && self::$closeSingleTags is allways true, this end with the /> ending the <svg making the </svg> orphan. Putting a space in

$svgs = array(
    Html::tag('svg', $attrs, '#')
);

makes $content not empty and creates the <svg........> </svg> and this is a valid one.

If there is another way to get <svg......></svg> without adding the space….
Maybe

public static function tag($tag, $htmlOptions = array(), $content = “”, $closeTag = true) {
$html = ‘<‘ . $tag . self::renderAttributes($htmlOptions);
if ($content === false) return $closeTag && self::$closeSingleTags && ($tag != 'svg') ? $html . ‘ />’ : $html . ‘>’; else
return $closeTag ? $html . ‘>’ . $content . ‘</’ . $tag . ‘>’ : $html . ‘>’ . $content;
}

• This reply was modified 3 years, 3 months ago by lofesa.

Hi @nextendweb_gabor

Each time I touch the $content === false changin it whit others condition, like empty($content) and so… the slider is not rendered at all or bad rendered.

Now I have no time to test, and don´t know if it may wordk… but can this be a way:

$svgs = array(
    Html::tag('svg', $attrs, '', false)
);

As far as Html::tag takes 4 arguments being the four true by default….

Hi @nextendweb_gabor

$svgs = array(
    Html::tag('svg', $attrs, '', false)
);

This don´t work, don´t render the image of the slider.

Making $content == false the background is half rended, don´t display noting beloww “General” “Size”

Asking if (empty($content)) get a blank page.

But after all I think:

public static function tag($tag, $htmlOptions = array(), $content = "", $closeTag = true) {
        $html = '<' . $tag . self::renderAttributes($htmlOptions);

        // ('' === false) -> results false
        if ($content === false) {
          // wrong result BUT is rigth $conten = "" evaluates as false
          // AND THEN GET THIS /> an
          return $closeTag && self::$closeSingleTags ? $html . ' />' : $html . '>'; 

        } else {
          // correct result FOR svg we need this result even if $content is false
          return $closeTag ? $html . '>' . $content . '</' . $tag . '>' : $html . '>' . $content;
        }
}

P.S. Done the test, get string(0) "" bool(false)

Hi

Don´t worry, I have copy of the files before get touched and restore it when goes wrong.

I´m a bit confused, if $content == false is true and $closeTag && self::$closeSingleTags is true, what we can spect in

if ($content === false) {
          return $closeTag && self::$closeSingleTags ? $html . ' />' : $html . '>'; 
        } else {
          return $closeTag ? $html . '>' . $content . '</' . $tag . '>' : $html . '>' . $content;
        }

I think that $html . ' />'

Is this rigth?