Support » Plugin: Broken Link Checker » PHP 7.3 deprecated code still not corrected

  • Resolved Malae

    (@malae)


    Hello,

    Broken Link Checker has a new owner for some time now and I hope that all the deprecated code will be cleaned up soon with an update to fix the warnings in PHP 7.4 which I posted more than 2 weeks ago together with the fix, which takes about 5 minutes to apply.

    However, I don’t understand why reports of of deprecated code made 5 months ago are ignored, especially when the fix was suggested.
    https://wordpress.org/support/topic/php-7-3-deprecated-code-warning/
    On most of my sites, I am still forced to run the old version 1.10.5 with my fixes, because when I try version 1.11.10, it still throws so many warnings.

    Warnings do not mean that the plugin will not work, but on a development site with debug enabled, it floods the log file, which makes sorting out other issues very tedious.

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Support Predrag Dubajic WPMU DEV Support

    (@wpmudev-support1)

    Hi @malae,

    Thanks for all the reports that you shared and both PHP 7.3 and 7.4 issues are on to-do list for version 1.11.11 which is currently being worked on.

    It might seem like the fix takes 5 minutes to apply but the code needs to be reviewed first, and since taking over the BLC plugin didn’t happen that long ago these processes are at the moment usually longer than with our other plugins developed by our team.
    All of the fixes also need to go through QA testing stage before it’s released publicly so we do appreciate your patience on this 🙂

    Cheers,
    Predrag

    Malae

    (@malae)

    Hello Predag,

    Thanks for your reply. The reason I posted the above is that my filter flag fix was posted more than 5 months ago. I do understand that some issues may take a lot of time to fix the code. With my limited abilities in PHP, I sometimes spend days to find a solution, if at all, but the filter flag and curly braces issues are no-brainers.
    The PHP 7.4 warning:

    FILE: /broken-link-checker/modules/extras/plaintext-url-parser-base.php
    WARNING AFFECTING LINE 82
    WARNING | The constant “FILTER_FLAG_HOST_REQUIRED” is deprecated since PHP 7.3

    simply requires removing the deprecated flag and preceding comma.

    The deprecated syntax warnings:

    PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /wp-content/plugins/broken-link-checker/idn/idna_convert.class.php on line 370
    PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /wp-content/plugins/broken-link-checker/idn/idna_convert.class.php on line 384
    PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /wp-content/plugins/broken-link-checker/idn/idna_convert.class.php on line 776
    PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /wp-content/plugins/broken-link-checker/idn/idna_convert.class.php on line 907
    PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in /wp-content/plugins/broken-link-checker/idn/transcode_wrapper.php on line 95
    PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated /wp-content/plugins/broken-link-checker/idn/transcode_wrapper.php on line 122

    only require the curly braces to be replaced by square brackets.

    Both of the above can be be done in a few minutes and don’t need extensive testing.

    Plugin Support Adam – WPMU DEV Support

    (@wpmudev-support8)

    Hello @malae

    I hope you’re well today!

    I apologize for the trouble. Please note that we took over the plugin only some time ago and getting familiar with all the reports, not to mention getting familiar with plugins code, all it’s “ups & downs” and everything that has to be reviewed, improved and possibly fixed might take some additional time.

    However, fixes planned for 1.11.11 version (as mentioned by my colleague Predrag above) are already undergoing preliminary QA tests (note: we need to make sure not only that a specific fix works but that it’s also compatible with other parts of the plugin and other implemented fixes). I don’t have an ETA but since things are already undergoing tests we can expect it to be published relatively soon, I believe.

    Kind regards,
    Adam

    Hello

    we have the same problem. It blocks our migration to PHP 7.4.

    Please, fix this issue.

    Plugin Support Adam – WPMU DEV Support

    (@wpmudev-support8)

    Hi @chrimah

    Our developers and QA team are working on the upcoming update that is expected to fix it. As mentioned earlier, if all the tests are passed as planned, it should be included with 1.10.11 release. I don’t have an ETA on it but it’s getting closer and should solve the issue once published.

    Kind regards,
    Adam

    Helllo Adam,

    Thank you for finally correcting all the PHP errors. I have been maintaining version 1.10.5 on my websites for the last two years and posting patches.

    I have seen no notices warnings, or errors after updating to version 1.11.11 in my development sites for the past 2 days and plan to update my active sites soon.

Viewing 6 replies - 1 through 6 (of 6 total)
  • You must be logged in to reply to this topic.