Hi Per,
Absolutely, will get these fixed up in the next version.
Thank YOU for reporting, it will help improve the plugin for everyone.
Jeff
Thread Starter
psn
(@psn)
Hi,
Any ETA for next version including fix for above mentioned issues?
Per
I’m currently working on a video course for Lynda.com, so won’t be able to get to this until probably August (ish).
Also, just to be clear, you said you were testing on PHP 7, correct? I ask because I run the plugin on many PHP-7 sites and do not see any errors.. It would help to have the complete errors you are getting (e.g., file names and line numbers). Please remove any sensitive path infos if posting here. Or if you would rather send the errors directly, you can do so using my contact form.
Thread Starter
psn
(@psn)
Hi Jeff,
You have the file and line numbers in my first but here you have it again:
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES in this file, widget-system-info.php
——————————————————————————————————————-
Line 695 | ERROR | Extension ‘mysql_’ is deprecated since PHP 5.5 and removed since PHP 7.0 – use mysqli instead.
Line 1007 | WARNING | INI directive ‘register_globals’ is deprecated since PHP 5.3 and removed since PHP 5.4.
Line 1016 | WARNING | INI directive ‘safe_mode’ is deprecated since PHP 5.3 and removed since PHP 5.4.
All these errors comes when we run PHP Compatibility plugin.
Perfect, will use this info when updating the plugin soon next week or so. Thanks again for the feedback and infos.
Thread Starter
psn
(@psn)
No problems, sorry for my late reply but has been on vacations. Looking forward to next release as we are planning to move soon to PHP 7.
Best regards,
Per
Hi Per,
After looking into this, I have resolved the reported ERROR in the upcoming version of the plugin.
For the two WARNINGS, those I believe are incorrect, as the plugin code is using ini_get() to check the value of two configuration options, which can be anything. I.e., there is no restriction on the argument that can be passed to ini_get()
.
It looks like your PHP-compatiblity plugin notices the arguments “register_globals” and “safe_mode” that are passed to ini_get()
, and incorrectly assumes that they refer to the actual directives, which they do not. They are simply arguments and totally safe.
Bottom line, the reported error is resolved. And the two reported warnings are incorrect because the code is 100% fine to use.
I hope that all makes sense. Let me know if I can elaborate on anything, glad to do so.
-
This reply was modified 7 years, 6 months ago by
Jeff Starr. Reason: clarity
Thread Starter
psn
(@psn)
Great and I will check with author of comp php7 check plugin why we get the warning of INI.
But as it is just a warning and the 2 argument can be used in combination it will work fine.
Per
-
This reply was modified 7 years, 6 months ago by
psn.
Yes let them know that ini_get()
accepts any string as an argument. The function simply checks if the option is set in config. So there is nothing wrong with checking either “register_globals” or “safe_mode”. This is why no errors are shown in PHP error log.
Thread Starter
psn
(@psn)
Yeah will do that. Just one quest as these 2 checks is only needed when you run lower version then 5.4 as both are removed in the higher version perhaps a remark on this is needed in your check if this is possible?
Thanks for quick support!
Per
-
This reply was modified 7 years, 6 months ago by
psn. Reason: Added one question