WordPress.org

Forums

P2
[resolved] Patch file for P2 to allow user scaling on mobile version (10 posts)

  1. ryansommers
    Member
    Posted 11 months ago #

    After talking with Lance on Twitter (https://twitter.com/simpledream/status/476874268081283072) I'm submitting this minor SVN .patch file to allow users to scale their display on the mobile version.

    The contents of the .patch file are available at:
    https://gist.github.com/ryansommers/165ac43e9e85e27ecefd

  2. Lance Willett
    Themer
    Posted 11 months ago #

    Thank you Ryan. I'll let you know once it's committed and ready for testing.

  3. Lance Willett
    Themer
    Posted 11 months ago #

    Do you think we should remove the p2_is_iphone() and serve the viewport element for all user agents?

  4. ryansommers
    Member
    Posted 11 months ago #

    That would actually make more sense. I wasn't connecting that it was being served to iPhone only at the moment, was just thinking mobile in general.

    If that were the case, is it still standard to have a meta viewport tag in the functions.php file, or would it move to header.php?

  5. Lance Willett
    Themer
    Posted 11 months ago #

    It can just move to header.php, serve it to all views, I think.

  6. ryansommers
    Member
    Posted 11 months ago #

    Okay, I updated the gist at https://gist.github.com/ryansommers/165ac43e9e85e27ecefd

    The "iPhone viewport meta tag" section is removed entirely from functions.php, and a proper viewport meta tag has been added to header.php that will be served to all devices.

  7. Lance Willett
    Themer
    Posted 11 months ago #

    Thanks Ryan! You rock.

  8. Lance Willett
    Themer
    Posted 11 months ago #

    Both these changes are now in the SVN repo, we'll push out to the WP.org directory with the next P2 release (probably a 2-3 weeks from now.)

  9. Kathryn
    Automattic Happiness Engineer
    Posted 10 months ago #

    Ryan - just wanted to let you know these changes are now live in version 1.5.5 of p2. Thanks again for the report and the patches.

  10. ryansommers
    Member
    Posted 10 months ago #

    Awesome, thanks Kathryn :)

Reply

You must log in to post.

About this Theme

About this Topic

Tags