Support » Plugin: Beautiful taxonomy filters » Pagination on filters with taxonomy slug

  • ResolvedModerator Francisco Torres

    (@frantorres)


    I think I found a bug during the development of a website.

    The thing is:

    I looked at rewrite rules and i found something like this:

    myCPT?(:/myTaxonomyRewriteSlug1/([^/]+))??(:/myTaxonomyRewriteSlug2/([^/]+))?page/([0-9]{1,})/?$

    So, it’s like the initial ‘/’ for page is not there.
    I edited in the plugin /admin/class-beautiful-taxonomy-filters-rewrite-rules.php:117

    $new_paged_rewrite_rule = $new_rewrite_rule . 'page/([0-9]{1,})';
    to
    $new_paged_rewrite_rule = $new_rewrite_rule . '/page/([0-9]{1,})';
    (just added initial / to page)

    Now this rewrite rule looks like
    myCPT?(:/myTaxonomyRewriteSlug1/([^/]+))??(:/myTaxonomyRewriteSlug2/([^/]+))?/page/([0-9]{1,})/?$

    And for now it’s working fine for me, i don’t know if this can be a problem for other things but i reviewed the rewrites and the only who change is this one.

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Jonathandejong

    (@jonathandejong)

    Hi Fransisco,

    Thank you!
    The support for rewritten taxonomy slugs where added not long ago so it’s absolutely possible I’ve missed this. It looks like you are correct indeed and I do not think this change would cause other issues.

    I’ll be sure to add this to the next version! Thank you again for helping out and supplying your code.

    i can confirm this bug. had the same problem with pagination and now it is working. do you already have an idea when you will be able to release the new version? will it be fixed there, so we do not have to keep an eye on this when updating? 😉

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Pagination on filters with taxonomy slug’ is closed to new replies.