Page rule setting with WPML

Hi Salvatore, just checked, seems to work fine!

Did you take a look to the WPML-related on cache purge issue too? Unfortunately I couldn’t yet, hope this week I’ll be able

Hi Salvatore, I think I’ve found the culprit.

So after some days leaving the website free to go while purging single-page here and there, I had time today to check the logs and this is what I came up with:

[2021-02-01 11:15:54] [cache_controller::purge_cache_on_post_edit] Purge Cloudflare cache for only post id 1658 and related contents
[2021-02-01 11:15:54] [cache_controller::purge_cache_queue_write] URLs in purge queue Array
(
    [purge_all] => 
    [urls] => Array
        (
            [0] => https://mydomain.com/en/product/jumper/?attribute_pa_groesse=xl
            [1] => https://mydomain.com/de/?taxonomy=product_visibility&term=outofstock
            [2] => https://mydomain.com/de/author/{edited:username}/
            [3] => https://mydomain.com/de/author/{edited:username}/feed/
            [4] => https://mydomain.com/de/
            [5] => https://mydomain.com/de/blog/
            [6] => https://mydomain.com/en/product/jumper/?attribute_pa_groesse=s
            [7] => https://mydomain.com/en/product/jumper/?attribute_pa_groesse=xs
            [8] => https://mydomain.com/en/product/jumper/?attribute_pa_groesse=m
            [9] => https://mydomain.com/en/product/jumper/?attribute_pa_groesse=l
            [10] => https://mydomain.com/en/product/t-shirt/?attribute_pa_groesse=l
            [11] => https://mydomain.com/de/author/{edited:username}/
            [12] => https://mydomain.com/de/author/{edited:username}/feed/
            [13] => https://mydomain.com/en/product/t-shirt/?attribute_pa_groesse=m
            [14] => https://mydomain.com/en/product/t-shirt/?attribute_pa_groesse=s
            [15] => https://mydomain.com/en/product/t-shirt/?attribute_pa_groesse=xl
            [16] => https://mydomain.com/en/product/t-shirt/?attribute_pa_groesse=xs
            [17] => https://mydomain.com/en/product/jumper/?attribute_pa_groesse=l-en
            [18] => https://mydomain.com/en/author/{edited:username}/
            [19] => https://mydomain.com/en/author/{edited:username}/feed/
            [20] => https://mydomain.com/en/
            [21] => https://mydomain.com/en/blog/
            [22] => https://mydomain.com/en/product/jumper/?attribute_pa_groesse=m-en
            [23] => https://mydomain.com/en/product/jumper/?attribute_pa_groesse=s-en
            [24] => https://mydomain.com/en/?taxonomy=product_visibility&term=outofstock
            [25] => https://mydomain.com/en/product/jumper/?attribute_pa_groesse=xl-en
            [26] => https://mydomain.com/en/product/jumper/?attribute_pa_groesse=xs-en
            [27] => https://mydomain.com/de/?product_visibility=outofstock
            [28] => https://mydomain.com/en/product/t-shirt/?attribute_pa_groesse=l-en
            [29] => https://mydomain.com/en/author/{edited:username}/
            [30] => https://mydomain.com/en/author/{edited:username}/feed/
            [31] => https://mydomain.com/en/product/t-shirt/?attribute_pa_groesse=m-en
            [32] => https://mydomain.com/en/product/t-shirt/?attribute_pa_groesse=s-en
            [33] => https://mydomain.com/en/product/t-shirt/?attribute_pa_groesse=xl-en
            [34] => https://mydomain.com/en/product/t-shirt/?attribute_pa_groesse=xs-en
        )

)

So I noticed that even some WooCommerce attributes with no archives resulted in purging URLs with GET parameters.

The ‘translation_priority’ tag mentioned before it’s a custom taxonomy too registerd by WPML Translation Management plugin.

So I changed the method get_post_related_links($postid) at line 991 to check if the taxonomy is public. If a taxonomy isn’t public, it do not have rewrites thus the term links are not pretty.

This way:

[...]
//Purge taxonomies terms URLs
        $postTypeTaxonomies = get_object_taxonomies($postType);
        
        foreach ($postTypeTaxonomies as $taxonomy) {
            // if taxonomy isn't public / has no rewrites we shouldn't be adding urls
            $taxonomy = get_taxonomy($taxonomy);
            if($taxonomy->public == false || $taxonomy->rewrite == false) {
                continue;
            }
[...]

It’s working fine now when I click “Purge cache for this page only” and on simple post edit/publish event (I have to wait for my custom cron job to start it that case, as it runs twice per hour).

It would be great if you could include this fix in future releases.

• This reply was modified 5 years, 4 months ago by Yui.
• This reply was modified 5 years, 4 months ago by frafor.

Sorry to bother, but the one proposed is a pretty quick fix with a huge impact on the plugin’s functionality, could you please answer?

Thank to you for the great work! ^_^ I’m just in a hurry because once this is fixed I have few ecommerces to move on cloudflare 🙂