Support » Plugin: WooCommerce » Page number no longer working on some product categories after update?

  • Resolved design_dolphin

    (@design_dolphin)


    On some product categories page numbers are no longer working after update???

    The page I need help with: [log in to see the link]

Viewing 12 replies - 1 through 12 (of 12 total)
  • Plugin Support Caleb Burks

    (@icaleb)

    Automattic Happiness Engineer

    And to confirm, are there more than 12 products in that category?

    If so, and the issue still occurs with no pagination, then let’s narrow this down to what other factors are involved as this isn’t an issue with just WooCommerce core.

    Could you please follow this guide: https://docs.woocommerce.com/document/woocommerce-self-service-guide/#section-4

    Temporarily deactivate all plugins except for WooCommerce and switch to a default WP theme and see if the issue still exists. If not, you can re-enable plugins one by one until you find the one causing the conflict.

    This could also be done a test/staging site if you have one.

    Yes, there are more than 12 products in that category.

    I just tested it with the Storefront theme, and the pagination does work there.

    Contacted the theme author to see what is going on.

    Plugin Support Caleb Burks

    (@icaleb)

    Automattic Happiness Engineer

    Does this happen with just the parent theme, and not just your child theme?

    And if so, is this the theme: https://themeforest.net/item/icelander-accessible-business-portfolio-woocommerce-wordpress-theme/20138825 ?

    And then also make sure the issue still occurs when using the latest version of the parent theme.

    _____

    If the issue does happen on the latest version of the parent theme, would you mind sending us a copy so we can look into what caused this change? You can submit a ticket at https://woocommerce.com/my-account and link to a downloadable zip file. Then post the ticket number here so I can look it up πŸ™‚

    1. Yes. the issue occurs on the parent theme
    2. Yes, that is the theme
    3. No, I don’t think I can send you a copy without permission of the theme author as it is licensed(?), sorry, but here is a link to the ticket that you can view:
    https://support.webmandesign.eu/forums/topic/woocommerce-3-3-update-broke-pagination/

    I can post back here if it is updated, so your team can stay up to date that way. What do you think?

    Plugin Support Caleb Burks

    (@icaleb)

    Automattic Happiness Engineer

    Don’t think the theme authors would mind, since we aren’t using the theme but rather trying to stay compatible with it :). The license is probably GPL, but it’s up to you if you want to send or not. No worries if not.

    And sure, you can update on this thread.

    The code is GPL I think, I’d have to check to be sure, but I don’t know about things like images, which can be copyrighted as it is not a free theme.

    I’ll update the thread when I know more.

    Plugin Support Caleb Burks

    (@icaleb)

    Automattic Happiness Engineer

    I found the same issue occurring in another one of the theme’s authors themes: Reykjavik. So think we’re good now on reproducing the issue.

    Will take a look and see if there’s something we can do to patch this up to stay compatible with outdated themes.

    Hi guys,

    I’m the author of Icelander and Reykjavik theme.
    No need to take an action from WooCommerce side on this issue. I’ve already resolved the issue and preparing the theme updates.

    @design_dolphin Please be patient until I release the theme update. Please note that WooCommerce reverted their 3.3 version plugin update as it caused many issues in other themes too, so, it’s technically not released yet either. https://woocommerce.wordpress.com/2018/01/30/woocommerce-3-3-has-been-released/

    You people rock. Thank you.

    Plugin Support Caleb Burks

    (@icaleb)

    Automattic Happiness Engineer

    @webmandesign,

    If you can, please test with the latest version of WC in the 3.3 branch here: https://github.com/woocommerce/woocommerce/tree/release/3.3.

    We’ve made some changes to better support themes using outdated templates, and would be good to make sure your upcoming changes don’t conflict with any of them.

    Please do reach out on Github if you found/find any other backwards-compatibility things we missed that could be accounted for.

    @icaleb

    Thank you, I can confirm my themes are working fine with WC3.3.1 now (the theme updates are still not released, possibly later today or tomorrow).

    To explain, I don’t override WooCommerce templates in my themes, but as I was loading the loop/pagination.php file using wc_get_template( 'loop/pagination.php' );.

    It seemed to me that woocommerce_pagination() function was just a wrapper for that code, so I’ve used that one directly. However, this has changed in WooCommerce 3.3 as some additional code was added to the woocoommerce_pagination() function and it was throwing PHP error of undefined $total variable in the loop/pagination.php file.

    I fixed this in my themes easily by calling woocommerce_pagination() function instead of the template file directly and I can see you guys have improved this in WooCommerce 3.3.1 too. So there will be no issues for me with WC3.3.1 and I’m ready for it πŸ˜‰

    Either the update of the theme or WooCommerce, or both have fixed it, and it is working.

    Thank you

Viewing 12 replies - 1 through 12 (of 12 total)
  • You must be logged in to reply to this topic.