Hi, @fpcsjames
I’d like to apologize for the issues with version 3.5. As of last night, we’ve released 3.5.0.2, which is actually a rollback to 3.4.2. If you upgrade to this version, it will revert all of the previous changes.
I would also like to clarify a few things:
- There is an off switch for the external JavaScript localization that was introduced in v3.3. Navigate to LiteSpeed Cache > Page Optimization > Localization Settings and set Localize Resources to
OFF. The option defaults to OFF, and external resources are not included in optimization as long as localization is disabled. The documentation for that can be found here.
- When we suggested turning off JS minification and combination, that was as a temporary workaround, and not a permanent solution. I’m sorry if that was not made clear.
We’ve seen your GitHub comment, thank you. We acknowledge the problem of generating a JS file for the footer and not allowing the location to be overridden. Additionally, the other issue you bring up here (no off switch for inline JavaScript optimization) is also problematic, we know. Hence the rollback.
We’re currently reworking all of the new optimization features of 3.5 to be more seamlessly implemented, and better customizable where necessary. If you’d like to join us on Slack, and be part of the conversation about future changes, and maybe help test the next version before it goes out, you’re welcome. Here’s the link to join, and you’ll want to go to the #wpcache channel once you get there.
Thank you for your feedback, and again, we apologize for any disruption this release may have caused!
@lclarke Thank you for your reply, which WordPress.org has emailed me about but unfortunately is not showing here yet. On JS localization, that is not the feature I am referring to. Yes, “Localize Resources” is toggleable in versions 3.5 and 3.5.0.1. This is entirely separate from and not related to the forced inclusion of external resources by JS Combine. The changelog for 3.5 states:
“JS Combine now combines external JS files, too.”
In 3.5 and 3.5.0.1, this is NOT toggleable, and is likely not desired by a vast majority of users. While Localize Resources uses a whitelist of domains from which localization is considered “safe”, 3.5’s JS Combine forces admins to use a blacklist to hopefully find and prevent all external includes that should not be happening. That’s not good, and it should never happen again. Inclusion of external resources as part of JS Combine must have a toggle switch, and must be off by default, full stop. Allow users to opt in if they wish.
I did see the 3.5.0.2 rollback update, and I am debating applying it. I’ll happily change my review to a five-star one should these important changes we’ve discussed happen.
Hi, @fpcsjames
I was just coming here to correct my previous statement actually. I see what you are referring to, and you are right. External resources are being included in JS Combine for 3.5. My bad.
This is part of the discussion we are having internally about how best to implement the new features for minimal disruption to the majority of users, so rest assured, it will be addressed. Thanks again for your feedback.
