Plugin works, but in-compatible with Maintenance plugin.

Viewing 9 replies - 1 through 9 (of 9 total)
  • Plugin Author Maje Media LLC

    (@majemedia)

    7 years, 5 months ago

    Hello,

    I just ran through some tests on all built in profile types and the admin bar is definitely hidden for everyone that has it.

    – Subscriber
    – Contributor
    – Author
    – Editor
    – Admin

    The plugin only has to be activated to work.

    Please let me know if you have any questions.

    One additional note… this only removes the admin bar form the front end. it does not touch the admin bar in the dashboard area.

    • This reply was modified 7 years, 5 months ago by Maje Media LLC. Reason: added additional note
    Thread Starter HelloImChase

    (@helloimchase)

    7 years, 5 months ago

    I wish I could remove the one star review, as I feel bad about it – but I tried everything to get this plugin to work, it only ever removed the front end toolbar for the Admin group, none of the others unfortunately.

    I suppose it could be conflicting with another plugin of mine

    Plugin Author Maje Media LLC

    (@majemedia)

    7 years, 5 months ago

    My testing is done with a regular installation of wordpress (no extra plugins).

    However, I did test it with WooCommerce as well (since that’s kinda why i created it in the first place) and it works correctly with the Customer & Shop Manager roles.

    What plugins do you have installed? I can dig a bit deeper and figure it out.

    Note: It may also be in your theme.

    If you search through your site’s code and look for this: show_admin_bar that’s the only thing that this plugin hooks into. If something else is using it then this won’t work.

    Plugin Author Maje Media LLC

    (@majemedia)

    7 years, 5 months ago

    Also, regarding the 1-star review. You can leave support requests instead of star reviews when you’re having problems with plugins.

    Thread Starter HelloImChase

    (@helloimchase)

    7 years, 5 months ago

    Yeah, It was my first time ever rating a plugin badly, I shouldn’t have done it. I was just frustrated about none of these plugins working correctly (I tried three, should have realized it was on my end).

    I just ran some standard troubleshooting and found out your plugin is incompatible with Maintenance by fruitfulcode (https://wordpress.org/plugins/maintenance/). When Maintenance is activated, the toolbar won’t go away with your plugin except for the admin group, weird.

    Anyway you can patch that?

    EDIT: Fixed bad review.

    • This reply was modified 7 years, 5 months ago by HelloImChase.
    Plugin Author Maje Media LLC

    (@majemedia)

    7 years, 5 months ago

    Thanks for the fix!

    Lines 105 – 112 of wp-content/plugins/maintenance/maintenance.php

    Looking at the maintenance plugin the following conditions are taken into account:

    if you are an admin: don’t run the code
    if you are not an admin: check for the maintenance options “admin bar enabled” and if the user is logged in then run the code and if the admin bar enabled option is disabled then hide the bar otherwise show the bar.

    Thread Starter HelloImChase

    (@helloimchase)

    7 years, 5 months ago

    Wow, one setting in Maintenance disabled and now your plugin works.

    Thanks for the help!

    Plugin Author Maje Media LLC

    (@majemedia)

    7 years, 5 months ago

    > Anyway you can patch that?

    Yeah… I’ll add it as an issue in github and hook in earlier so that other plugins using the default priority on the hook can override my settings.

    Plugin Author Maje Media LLC

    (@majemedia)

    7 years, 3 months ago

    Chase,

    Just wanted to follow up on this. We’ve updated the plugin to have a lower priority than default so that other plugins can override this plugin’s functionality should that be desired.

    Version 1.1.0 is available now.

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘Plugin works, but in-compatible with Maintenance plugin.’ is closed to new replies.