Support » Plugin: AMP » obnoxious since v.2.0.0 / WP 5.5

  • In the past, this plugin worked flawlessly for me, but since version 2.0.0 / WP 5.5 I’m getting warning popups not just upon publishing, but with every single page / post update, as well as with every intermediate saving while writing a post. The warnings report multiple illegal <script> tags with numerous plugins, the page header, the theme (possibly) — I’m not in a position simply to switch theme, to remove or change an entire series of plugins, and/or to change all of my 500+ blog posts. I saw no alternative to switching to another AMP plugin. Dreadful. You appear to blame the user for using themes / plugins that worked flawlessly for several years. JavaScript may be undesirable in an AMP environment — but screwing the enduser for changes that must be implemented by plugin & theme authors etc. is not the way to introduce a new JS policy.

    • This topic was modified 4 months, 3 weeks ago by rkyburz.
Viewing 11 replies - 1 through 11 (of 11 total)
  • Plugin Support James Osborne

    (@jamesosborne)

    Sorry to read your review, we’ve worked hard on this release so it’s never good to hear such feedback. I didn’t see a support topic open which would have been helpful to assist you with any concerns, but hopefully the below answers some of your concerns.

    Firstly I suspect you may have been using the plugin in reader mode. Since version 2.0 we’ve made changes to the plugins reader mode, to expose validation errors, although this can be switched off. Previous versions of the plugin automatically handled validation errors by removing scripts and invalid elements although users may not have been aware that these validation errors existed. While reader mode can still handle these as before it highlights such errors in the validation tool to display the source of such errors. We’ve wrote a sticky post on this explaining it better than I can here.

    You can turn off AMP Developer Tools in your WordPress user profile which would give you the reader mode experience similar to previous versions.

    I saw no alternative to switching to another AMP plugin.

    I understand, if you find this plugin isn’t for you that’s no problem. If you happen to revisit the plugin I suggest switching off AMP developer tools and checking out the different themes available via reader mode, a new feature of version 2.0. You’ll hopefully not only have the same reader mode experience as previous versions but you can choose your AMP theme.

    You appear to blame the user for using themes / plugins that worked flawlessly for several years.

    There haven’t been modifications to how the plugin highlights invalid themes or plugins other than reader mode users can now view validation errors which always existed.

    is not the way to introduce a new JS policy.

    Custom JavaScript is a restriction of the AMP framework as opposed to the plugin, we don’t have any additional restrictions. You’ll find the same incompatibilities exist with other AMP plugins.

    If you were using the plugin in transitional or standard mode please share your Site Health information privately using this form and we can hopefully assist.

    thanks for getting back to me on this. I have spent some two full days switching between all three modes (some were much worse than others), I even checked with the author of the Gutenberg “Stackable” plugin (which seems to cause some of the <script> errors) — needless to say that he was unable to fix this instantly. I tried all plugin options, checked my header hooks (I’m using the Exhibit / GeneratePress theme). I think I encountered the advice about turning off AMP developer tools, but was unable to locate this in my menus — at some point I felt that this was simply taking too much of my time … I have temporarily switched back to your plugin and found all error logs still to be there (shouldn’t these be deleted when I delete the plugin?), I’m sending you the site health information separately. I understand that the JS policy in AMP is not new — but the way and the persistence & abundance with which I (as user / site admin) was confronted with these error messages is not exactly nice, to say the least.

    Plugin Support James Osborne

    (@jamesosborne)

    Thanks for the update. I’ve checked some of your plugins and indeed some of the front end plugins you have active are likely to cause validation errors.

    In relation to the notices you encounter I understand and I’ll pass on your feedback. You can also raise any concerns or feature requests using the plugins GitHub repository. You’ll find the developer tools option below (Users > Profile):

    You may also find the plugins new suppression tool useful in order to limit notices. This will deactivate plugins in AMP URLs only.

    I also noticed you are using GeneratePress. You can use this theme addon to ensure your navigation menu works in AMP, which is one less problem to fix. Download the zip file and upload as a regular WordPress plugin.

    Is there anything else you would like me to check on your website, or any errors you encounter which you’re unsure of? You might also find the plugins FAQs section on the website useful.

    Hi James, thanks again for getting back to me so quickly. I’ll have a detailed look at this tonight. For now, let me just inject one small(ish) thing, as you mentioned AMP plugin modes: I find the GUI for switching between modes (Settings screen) highly confusing: the top seems clear — “Template mode”, followed by a button and an icon — but further down it is anything but clear which button / icon is which mode — especially as I don’t see a button to select the Reader mode. Some horizontal rulers / extra spacing / a different arrangement might help. am I missing something here?

    Plugin Support James Osborne

    (@jamesosborne)

    Great feedback, I’ll be sure to pass that on, or maybe @albertomedina can follow up with you here.

    In short when you click on any of the modes it’s highlighted, but that mode will not become active until you press the “Save Changes” button below.

    Yes, I noted that latter point, but remain confused about the Reader mode…

    Plugin Author albertomedina

    (@albertomedina)

    @rkyburz Thanks for the feedback. We will take a detailed look at it and address it.

    Since you indicated that the plugin has worked flawlessly for you, please consider updating your one-star review. We are making big efforts to build the best plugin we can, and I think a one-star review does not reflect the reality of the plugin.

    Hi @albertomedina, I have “upgraded” my review to ***, reflecting the current state of usability (and the support that you are offering). I may further upgrade when I’m able to get (most of) these issues resolved. Will revisit the issue tonight / tomorrow, as time permits. I still feel flooded with those warning messages. The post currently in the works reports “There are 40 issues from AMP validation which need review. The issues are not directly due to content here. The invalid markup has been automatically removed”. As these warnings are not directly related to the content of my post, I don’t see why I need to see a new instance of that same warning with every intermediate save! 🙁

    • This reply was modified 4 months, 3 weeks ago by rkyburz.
    • This reply was modified 4 months, 3 weeks ago by rkyburz.
    • This reply was modified 4 months, 3 weeks ago by rkyburz.
    Plugin Author albertomedina

    (@albertomedina)

    Thank you. And thank you for your valuable feedback!

    sorry, I amended my last response after yours … here’s the latest addition again:

    The post currently in the works reports “There are 40 issues from AMP validation which need review. The issues are not directly due to content here. The invalid markup has been automatically removed”. As these warnings are not directly related to the content of my post, I don’t see why I need to see a new instance of that same warning with every intermediate save! 🙁

    Plugin Author Weston Ruter

    (@westonruter)

    I think I encountered the advice about turning off AMP developer tools, but was unable to locate this in my menus — at some point I felt that this was simply taking too much of my time …

    You’re right that this can be difficult to find. We should consider elevating this user-profile setting to the AMP settings screen to make it easier to find.

    I have temporarily switched back to your plugin and found all error logs still to be there (shouldn’t these be deleted when I delete the plugin?)

    We have an issue open to delete all plugin data at uninstallation. This should be coming in v2.1. See amp-wp#3210.

    I understand that the JS policy in AMP is not new — but the way and the persistence & abundance with which I (as user / site admin) was confronted with these error messages is not exactly nice, to say the least.

    Understood. We’ve just realized v2.0.1 which turns off AMP Developer Tools by default when in Reader mode. This eliminate the new abundance of errors.

    Nevertheless, the errors are being displayed because some markup is being removed by the AMP plugin in order to make the pages valid AMP. It’s also important to make sure that you are aware the plugin is doing this. Obviously we haven’t landed on the best way to communicate this. We have an issue open to improve placement of the validation error sin the block editor to make them less alarming and more helpful. See amp-wp#3821.

    For now, let me just inject one small(ish) thing, as you mentioned AMP plugin modes: I find the GUI for switching between modes (Settings screen) highly confusing: the top seems clear — “Template mode”, followed by a button and an icon — but further down it is anything but clear which button / icon is which mode — especially as I don’t see a button to select the Reader mode. Some horizontal rulers / extra spacing / a different arrangement might help. am I missing something here?

    Would you be able to create a screenshot to share with us, perhaps annotate it with what is not making sense?

    The screen should look like this.

    Is the issue that the Save Changes button is not in view until you scroll to the bottom? If this button were sticky on the bottom of the window would this address your confusion?

    I’m getting warning popups not just upon publishing, but with every single page / post update, as well as with every intermediate saving while writing a post. The warnings report multiple illegal <script> tags with numerous plugins, the page header, the theme (possibly).

    I still feel flooded with those warning messages. The post currently in the works reports “There are 40 issues from AMP validation which need review. The issues are not directly due to content here. The invalid markup has been automatically removed”. As these warnings are not directly related to the content of my post, I don’t see why I need to see a new instance of that same warning with every intermediate save! 🙁

    Again, I recommend turning off AMP Developer Tools in your WordPress user profile settings. This will eliminate displaying the warning messages. We need to do better at communicating these errors to users.

    • This reply was modified 4 months, 3 weeks ago by Weston Ruter.
Viewing 11 replies - 1 through 11 (of 11 total)
  • You must be logged in to reply to this review.