WordPress.org

Forums

Better Internal Link Search
[resolved] Not working since WP 3.9 upgrade (11 posts)

  1. websupportguy
    Member
    Posted 1 year ago #

    I'm duplicating this report because the OP's heading wasn't very helpful. Since I upgraded to WP3.9 this plugin is no longer automatically finding the appropriate link for highlighted text. It was really good up to now.

    https://wordpress.org/plugins/better-internal-link-search/

  2. alexgagi
    Member
    Posted 1 year ago #

    This plugin is wonderful, but I'm sorry it's broken. It has stopped working as said before.

  3. Occult World
    Member
    Posted 1 year ago #

    I am SO sorry this plugin stopped working. With more than 5000 posts on my site it was so incredible helpful.
    I hope the developers will fix this. I really hope so - because it is a wonderful plugin.

  4. Brady Vercher
    Member
    Plugin Author

    Posted 1 year ago #

    Hey guys, I've been out of town, so I'm just now getting a chance to look into this. As far as I can tell, the only thing not working is that selected text is no longer searched automatically?

    WordPress 3.9 changed the way that modal window operates and doesn't provide a way to know when it's visible like it did in previous versions. In all likelihood, this will require a change to core in order to fix. I'll open a ticket when I have a chance.

    Thanks,
    Brady

  5. websupportguy
    Member
    Posted 1 year ago #

    Hi Brady, nice to know you're still on the job. Yes, it's just not detecting selected text. Will be good to have it working again. Thank you.

  6. websupportguy
    Member
    Posted 1 year ago #

    Hi Brady, any progress on this yet?

    Tony

  7. Brady Vercher
    Member
    Plugin Author

    Posted 1 year ago #

    Hey Tony, I submitted a patch to core that needs to be implemented first, so hopefully that'll be included in WP 3.9.2. You can follow that ticket here.

    - Brady

  8. ambrosite
    Member
    Posted 1 year ago #

    If that patch were to be added to the core (and let's hope that it is), what would need to be added/changed in your plugin code in order to make it work with the new event?

  9. Brady Vercher
    Member
    Plugin Author

    Posted 1 year ago #

    I haven't tested this, but if that patch gets committed, then replacing this line with the following code should do it:

    $('#wp-link-wrap').on('open', function() {

  10. ambrosite
    Member
    Posted 1 year ago #

    Brady,

    Thank you, I'll give that a try. In the meantime you might want to check out this plugin:

    http://wordpress.org/plugins/b09-link-to-existing-content/

    It does something similar to yours, except that they are deregistering wplink.js and replacing it with their own modified version. I realize it is a radical solution to replace an entire core file just to fix one line, but if they aren't going to put your patch into the core it might be the only solution. I really need to get this working so I may end up doing it myself.

  11. Brady Vercher
    Member
    Plugin Author

    Posted 1 year ago #

    I'm not really wanting to take it that far for this particular feature, but if you're intent on making that change I mentioned, you could proxy the jQuery show method to force the event to be triggered (instead of waiting for the patch in core). Just drop this in at the top or bottom of internal-link-manager.js.

    (function( $, jQueryShow ){
    	$.fn.show = function(){
    		if ( 'wp-link-wrap' === this.attr( 'id' ) ) {
    			this.trigger( 'open' );
    		}
    		return jQueryShow.apply( this, arguments );
    
    	};
    })( jQuery, jQuery.fn.show );

Topic Closed

This topic has been closed to new replies.

About this Plugin

  • Better Internal Link Search
  • Frequently Asked Questions
  • Support Threads
  • Reviews

About this Topic

Tags

No tags yet.