Hi Gal,
First question, what version of Enable Media Replace you have installed?
Second, could you please run a quick test? Please do the following:
– Deactivate all plugins except ShortPixel.
– Activate all plugins, one by one.
– After each single activation, check if the issue still happens. This will help you identify what plugin causes this (if it is indeed another plugin).
– If that doesn’t help, please send us more information about how exactly you see that thumbnails aren’t being regenerated.
Thank you,
Hi Gerard,
I’ve installed v3.6.0.
Looks like Image Regenerate & Select Crop is the culprit. When it’s deactivated, thumbnails are regenerated, optimised and renamed.
Importantly, once the file is loaded, Image Regenerate & Select Crop happily regenerates its thumbnails, which are then optimised by EWWW and renamed.
Cheers,
Gal
-
This reply was modified 2 years, 6 months ago by
Gal Baras.
Thanks for letting us know, Gal!
Sure thing. I’ve also tried to find the problem myself, but couldn’t. Hopefully, you can do it quicker than I can.
A couple of comments from looking at the code:
thumbnail_updater.php seems like a class file, but “lives” in the plugin’s home directory, instead of the classes subdirectory- On lines 488-496 of
classes/replacer.php, seems like the variable $side should be $size
-
P.S. Let’s leave this thread as unresolved until a fix is released.
Hi Gal,
I think there’s been some confusion here. Can you please clarify where the issue is located? From what you say, if “Image Regenerate & Select Crop” is deactivated, everything works correctly, so my understanding is that the issue is on their side.
Thank you,
Plugin conflicts aren’t that simple. The other plugin also works well in regular uploads, and MAY only have issues when images are replaced by YOUR plugin.
Please investigate this further. In the meantime, I will cross-report.
Gal,
In order to investigate this further, could you please tell us step by step how to reproduce the issue? Please indicate what option we should choose, expected results, etc. Screenshots may also help :-).
Thank you,
Thank you, Gal.
I was able to reproduce the issue, but when I try to do the same with reGenerate Thumbnails Advanced, which does the same function, it works correctly.
So again, it all looks like an issue coming from the other side: Enable Media Replace kicks off the wp_handle_upload action, and does wp_generate_attachment_metadata, usually the hooks plugins listen to.
All of this is done in the Replacer.php -> replaceWith function. You should check if the other plugin listens to that properly.
I hope that helps!
Thank you for this. Actually, wp_handle_upload is a filter, not an action, and wp_generate_attachment_metadata() is a function with a similarly-named filter. Either way, I’ve relayed this to the other plugin’s author.
Have you tested this at all? Just assuming your plugin is doing the right thing seems a bit much. I don’t think this is resolved yet.
Please try to replicate and isolate the issue.
Hi Gal,
Yes, we tested it and our developers took a look at the issue.
From our side, everything is working properly: EMR does the job it’s supposed to do and signals to regenerate the thumbnails. Other plugins like reGenerate Thumbnails Advanced work properly.
Have a nice Sunday!
FYI, this issue has been resolved by changing action priorities in Image Regenerate & Select Crop.
Thanks, Gal, for letting us know!
