Normalize the plugin code

  • timotheemoulin

    (@timotheemoulin)


    3 years, 11 months ago

    Hi,

    I would love to use your plugin but it fails to work on my specific setup because you are fetching your options before any other hook can be triggered which means that no one can interact with it.

    Can you tell the reason why you are calling $loginlockdownOptions = get_loginlockdownOptions(); on the main script instead of only when you need it?

    I would advise some refactor too to be compliant with WP code style convention (I’m not an expert for that though).

    I would also recommend to rename the option as all WP options are snake case.

    Would you agree on a fork and pull request?

Viewing 4 replies - 1 through 4 (of 4 total)
  • Thread Starter timotheemoulin

    (@timotheemoulin)

    3 years, 11 months ago

    If you are interested in a collaboration, here is my fork repository.

    https://github.com/timotheemoulin/wp-login-lockdown

    mvandemar

    (@mvandemar)

    3 years, 11 months ago

    @timotheemoulin – there are other priorities I have over the naming conventions at this point. I will look into where I am loading the options, although you do know that the login form can technically exist on any non-admin page, right? I am sure it can still be optimized though.

    I will look at the fork when I can, thank you for your contributions. 🙂

    -Michael

    Thread Starter timotheemoulin

    (@timotheemoulin)

    3 years, 11 months ago

    Hey!

    Yeah that’s not only about normalization. They’re also some fixed that might be needed especially regarding the plugin activation that doesn’t work on a windows server.

    Let me know of you have some times to setup an issue tracking list that we can collaborate on.

    Thread Starter timotheemoulin

    (@timotheemoulin)

    3 years, 11 months ago

    I just checked and I don’t see any issue on a frontend embedded login form.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Normalize the plugin code’ is closed to new replies.