Excellent feedback, Jason. Thank you!! I will include a fix for this in the next update. Probably sometime this month. Thanks again. This is very helpful.
Jason, I added a fix for this in version 1.2.1. Please feel free to let me know if it’s still a problem after you update. I’ll close this ticket soon if I don’t hear from you. Thanks again.
Hey, Aaron,
I was going to check, but—since updating—I’m now seeing the following error message printed on the FRONT END of the public page:
Undefined variable: size_width in /wp-content/plugins/before-after-images-for-divi/includes/modules/BeforeAfterImage/BeforeAfterImage.php on line 376
I’m hoping that we fix this much more urgent problem first, then I can get back to verifying the fix for the original problem in the visual builder.
Thanks!
I seem to have fixed the problem, but it may not be 100% correct. With the help of the related solution at https://stackoverflow.com/a/4261200 , I changed
if($size_width != ''){
to
if($size_width ?? ''){
on line 376. The error no longer appears on the public page, and everything seems to be working fine in the back end, as well. You may want to verify yourself, though, because I’m no PHP expert. 😉
@jasonbear Gah, sorry about that. Do you have have WP_DEBUG set to true in wp-config.php?
define( ‘WP_DEBUG’, true );
..default is define( ‘WP_DEBUG’, false );
That may be why you’re seeing the error on the front-end. I will post a fix in v1.2.3 asap.
@jasonbear Can you also tell me what version of PHP you’re using? I wonder if that might be linked to the problem. After testing with WP_DEBUG set to true, I’m not yet seeing any errors from version 1.2.2 of this plugin on my staging site using PHP version 7.2, or on a local development site using version 7.1.
Yes, I do have debug set to “On.” I forgot to revert it after doing some unrelated troubleshooting.
The site is on HostGator, and the newest available is 7.1 (which is what I’m running).
-
This reply was modified 5 years, 1 month ago by
jasonbear.
Ok, great. Thanks for your reporting on these recent threads. It’s helped make the plugin better and I included acknowledgements to you in the readme notes for the latest updates. Hope the default slider position feature is working well for you. I’ll push an update to resolve the Debug errors but otherwise, if all is working for you when Debug is off, I’ll start to close out these Support Threads.
Cool, thanks!
No more problems with the secure image(s), BTW. 🙂
