@kniebremser – Do you have any specifics on this?
If you are referring to updates being made at https://translate.wordpress.org/ that is well outside our scope, if you are referring to something specifically within our plugin not meeting i18n implementations we would be more than happy to review that.
Thanks!
– Cais.
t.w.o scans all php files in the plugin directory on translatable strings. It is stuck somewhere an error in the php-files. It’s enough a strained ' or " out
I already have found two strained '.
@kniebremser – I am not certain what you are referring to with strained ‘, can you provide an example of what you have found?
Thanks!
– Cais.
in show_return_link.php line 16:
<?php echo checked(1, intval($show_return_link)); ?>'>
in show_altview_link.php line 16:
<?php echo checked(1, intval($show_alternative_view_link)); ?>'>
in media-upload.php line 193 is a strained ;
<select id="select_gal" name="select_gal" style="width:120px;">;
in watermarks-tab.php line 44 is missed >
</td
I’d say you worried a reasonable tool to check the plugin for possible errors.
and a real thick Hammer
in display_tab_js.php line 1455:
for (var i=0; i<parts.length; i++) {
the closed tag for parts.length is missed
@kniebremser – Thanks for all of these details, I have made sure to submit a patch to correct them into our bug tracker system.
I can see each of the listed items as potential problem except the last (although patched to correct all the same). The last item is used as limiting value not a “tag” and as such should be fine as is … I am suggesting i < parts.length all the same.
Thanks, again!!
– Cais.
Hi!
A new version has been released without rectifying the errors. What I have to think of you, I know now.
@kniebremser – The issue you brought forward was outside our current sprint for this release cycle. It will be reviewed in the next sprint planning meeting for NextGEN Gallery.
Thanks!
– Cais.
Thanks kniebremser! Sorry for the delay on these; I’ve been really busy lately moving to a new state.
I’ve checked in a fix for everything but display_tab_js, which seems to be correctly formed with an ending brace. There is a braceless if/else – could that be what you mean?
I have two html errors found in the file manage-images.php.
In the lines 318 and 327 are each opening <form id>.
For one line is a closed </form> in line 465.
The Second </form> is missed.
The error has found the Neon Eclipse tool.
in display_tab_js.php line 1455:
for (var i=0; i<parts.length; i++) {
Neon eclipse recognizes <parts.length as opening html-tag.
@kniebremser – You are also welcome to send these issues in a PR on our development repository here: https://bitbucket.org/photocrati/nextgen-gallery/pull-requests/
Thanks!
– Cais.
