Nice work

  • pirossi

    (@pirossi)


    9 years ago

    This is a good plugin but I have a suggestion for an improvement.
    I changed the link’s href attribute from ‘#’ to ‘javascript:void(0)’ to prevent a page from jumping to the top when user click on the share link.

Viewing 1 replies (of 1 total)
  • Plugin Author Rhys Wynne

    (@rhyswynne)

    9 years ago

    Hi there,

    Thanks for the nice review :).

    Would you be interested in submitting it as a Pull Request here? – https://github.com/rhyswynne/inline-tweet-sharer/. I can add it in & give you credit so you don’t have to make the changes every time I do an update 🙂

    If not, don’t worry, I’ll try and remember.

Viewing 1 replies (of 1 total)
  • The topic ‘Nice work’ is closed to new replies.